leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: sm750fb: use BIT macro for VGA_CONFIGURATION single-bit fields

Browse Source 
Replace complex defintion of VGA_CONFIGURATION register fields with BIT()
macro and use open-coded implementation for VGA_CONFIGURATION
manipulations.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mike Rapoport 2016-02-10 18:34:00 +02:00 committed by Greg Kroah-Hartman
parent cf25a70436
commit d97981431f
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/sm750fb/ddk750_chip.c
View File

@ -211,8 +211,7 @@ int ddk750_initHw(initchip_param_t *pInitParam)
if (getChipType() != SM750LE) {
/* set panel pll and graphic mode via mmio_88 */
reg = PEEK32(VGA_CONFIGURATION);
reg = FIELD_SET(reg, VGA_CONFIGURATION, PLL, PANEL);
reg = FIELD_SET(reg, VGA_CONFIGURATION, MODE, GRAPHIC);
reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
POKE32(VGA_CONFIGURATION, reg);
} else {
#if defined(__i386__) || defined(__x86_64__)

8
drivers/staging/sm750fb/ddk750_reg.h
View File

@ -548,12 +548,8 @@
#define VGA_CONFIGURATION 0x000088
#define VGA_CONFIGURATION_USER_DEFINE 5:4
#define VGA_CONFIGURATION_PLL 2:2
#define VGA_CONFIGURATION_PLL_VGA 0
#define VGA_CONFIGURATION_PLL_PANEL 1
#define VGA_CONFIGURATION_MODE 1:1
#define VGA_CONFIGURATION_MODE_TEXT 0
#define VGA_CONFIGURATION_MODE_GRAPHIC 1
#define VGA_CONFIGURATION_PLL BIT(2)
#define VGA_CONFIGURATION_MODE BIT(1)
#endif