From d5cfb0ff2e628ae07f7226e7cfe8684b7c186e0e Mon Sep 17 00:00:00 2001 From: Christian Gromm Date: Fri, 9 Sep 2016 15:25:36 +0200 Subject: [PATCH] staging: most: hdm-usb: use defined error codes This patch replaces return values with defined error codes to indicate an exception. Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman --- drivers/staging/most/hdm-usb/hdm_usb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index da47253f0f34..5d62d1bf4dc3 100644 --- a/drivers/staging/most/hdm-usb/hdm_usb.c +++ b/drivers/staging/most/hdm-usb/hdm_usb.c @@ -801,17 +801,17 @@ static int hdm_update_netinfo(struct most_dev *mdev) if (!is_valid_ether_addr(mdev->hw_addr)) { if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_HI, &hi) < 0) { dev_err(dev, "Vendor request \"hw_addr_hi\" failed\n"); - return -1; + return -EFAULT; } if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_MI, &mi) < 0) { dev_err(dev, "Vendor request \"hw_addr_mid\" failed\n"); - return -1; + return -EFAULT; } if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_LO, &lo) < 0) { dev_err(dev, "Vendor request \"hw_addr_low\" failed\n"); - return -1; + return -EFAULT; } mutex_lock(&mdev->io_mutex); @@ -826,7 +826,7 @@ static int hdm_update_netinfo(struct most_dev *mdev) if (drci_rd_reg(usb_device, DRCI_REG_NI_STATE, &link) < 0) { dev_err(dev, "Vendor request \"link status\" failed\n"); - return -1; + return -EFAULT; } mutex_lock(&mdev->io_mutex); @@ -1116,7 +1116,7 @@ static ssize_t store_value(struct most_dci_obj *dci_obj, reg_addr = DRCI_REG_BASE + DRCI_COMMAND + ep * 16; val = 1; } else - return -EIO; + return -EFAULT; err = drci_wr_reg(dci_obj->usb_device, reg_addr, val); if (err < 0)