forked from Minki/linux
[media] hdpvr: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
5338c16905
commit
d486b94b26
@ -217,8 +217,7 @@ int hdpvr_register_i2c_adapter(struct hdpvr_device *dev)
|
||||
|
||||
hdpvr_activate_ir(dev);
|
||||
|
||||
memcpy(&dev->i2c_adapter, &hdpvr_i2c_adapter_template,
|
||||
sizeof(struct i2c_adapter));
|
||||
dev->i2c_adapter = hdpvr_i2c_adapter_template;
|
||||
dev->i2c_adapter.dev.parent = &dev->udev->dev;
|
||||
|
||||
i2c_set_adapdata(&dev->i2c_adapter, dev);
|
||||
|
Loading…
Reference in New Issue
Block a user