leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extcon: sm5502: Use devm_regmap_add_irq_chip()

Browse Source 
Use devm_regmap_add_irq_chip() to avoid having to remove the
irqchip explicitly in sm5502_muic_i2c_remove().

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
Stephan Gerhold 2021-05-31 15:34:33 +02:00 committed by Chanwoo Choi
parent dc11fc2991
commit d3a213d23c
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/extcon/extcon-sm5502.c
View File

@ -599,8 +599,8 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
/* Support irq domain for SM5502 MUIC device */ /* Support irq domain for SM5502 MUIC device */
irq_flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT | IRQF_SHARED; irq_flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT | IRQF_SHARED;
ret = regmap_add_irq_chip(info->regmap, info->irq, irq_flags, 0, ret = devm_regmap_add_irq_chip(info->dev, info->regmap, info->irq, irq_flags,
&sm5502_muic_irq_chip, &info->irq_data); 0, &sm5502_muic_irq_chip, &info->irq_data);
if (ret != 0) { if (ret != 0) {
dev_err(info->dev, "failed to request IRQ %d: %d\n", dev_err(info->dev, "failed to request IRQ %d: %d\n",
info->irq, ret); info->irq, ret);
@ -660,15 +660,6 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
return 0; return 0;
} }
static int sm5502_muic_i2c_remove(struct i2c_client *i2c)
{
struct sm5502_muic_info *info = i2c_get_clientdata(i2c);
regmap_del_irq_chip(info->irq, info->irq_data);
return 0;
}
static const struct of_device_id sm5502_dt_match[] = { static const struct of_device_id sm5502_dt_match[] = {
{ .compatible = "siliconmitus,sm5502-muic" }, { .compatible = "siliconmitus,sm5502-muic" },
{ }, { },
@ -713,7 +704,6 @@ static struct i2c_driver sm5502_muic_i2c_driver = {
.of_match_table = sm5502_dt_match, .of_match_table = sm5502_dt_match,
}, },
.probe = sm5022_muic_i2c_probe, .probe = sm5022_muic_i2c_probe,
.remove = sm5502_muic_i2c_remove,
.id_table = sm5502_i2c_id, .id_table = sm5502_i2c_id,
}; };