leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NFS: Use size_t for storing name lengths

Browse Source 
Clean up: always use the same type when handling buffer lengths.  As a
bonus, this prevents a mixed sign comparison in idmap_lookup_name.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Chuck Lever 2007-12-20 14:54:49 -05:00 committed by Trond Myklebust
parent a661b77fc1
commit d24aae41b4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/nfs/idmap.c
View File

@ -74,7 +74,7 @@ module_param_call(idmap_cache_timeout, param_set_idmap_timeout, param_get_int,
struct idmap_hashent { struct idmap_hashent {
unsigned long ih_expires; unsigned long ih_expires;
__u32 ih_id; __u32 ih_id;
int ih_namelen; size_t ih_namelen;
char ih_name[IDMAP_NAMESZ]; char ih_name[IDMAP_NAMESZ];
}; };
@ -193,7 +193,7 @@ idmap_lookup_id(struct idmap_hashtable *h, __u32 id)
* pretty trivial. * pretty trivial.
*/ */
static inline struct idmap_hashent * static inline struct idmap_hashent *
idmap_alloc_name(struct idmap_hashtable *h, char *name, unsigned len) idmap_alloc_name(struct idmap_hashtable *h, char *name, size_t len)
{ {
return idmap_name_hash(h, name, len); return idmap_name_hash(h, name, len);
} }
@ -381,7 +381,7 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
struct idmap_msg im_in, *im = &idmap->idmap_im; struct idmap_msg im_in, *im = &idmap->idmap_im;
struct idmap_hashtable *h; struct idmap_hashtable *h;
struct idmap_hashent *he = NULL; struct idmap_hashent *he = NULL;
int namelen_in; size_t namelen_in;
int ret; int ret;
if (mlen != sizeof(im_in)) if (mlen != sizeof(im_in))