leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cxl_getfile(): fix double-iput() on alloc_file() failures

Browse Source 
Doing iput() after path_put() is wrong.

Cc: stable@vger.kernel.org
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2018-06-09 09:43:13 -04:00
parent b4e7a7a88b
commit d202797f48
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/misc/cxl/api.c
View File

@ -103,15 +103,15 @@ static struct file *cxl_getfile(const char *name,
d_instantiate(path.dentry, inode); d_instantiate(path.dentry, inode);
file = alloc_file(&path, OPEN_FMODE(flags), fops); file = alloc_file(&path, OPEN_FMODE(flags), fops);
if (IS_ERR(file)) if (IS_ERR(file)) {
goto err_dput; path_put(&path);
goto err_fs;
}
file->f_flags = flags & (O_ACCMODE | O_NONBLOCK); file->f_flags = flags & (O_ACCMODE | O_NONBLOCK);
file->private_data = priv; file->private_data = priv;
return file; return file;
err_dput:
path_put(&path);
err_inode: err_inode:
iput(inode); iput(inode);
err_fs: err_fs: