leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

slimbus: core: do not call device_status under a lock

Browse Source 
Calling device_status callback under a lock would prevent drivers
to do any slimbus trasactions which would invoke this lock like
get_laddr(). Remove this unnecessary lock!

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Srinivas Kandagatla
2019-01-14 13:44:47 +00:00
committed by Greg Kroah-Hartman
parent 8631f940b8
commit cfb32101ba
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/slimbus/core.c
View File

@@ -466,6 +466,7 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev,
sbdev->laddr = laddr; sbdev->laddr = laddr;
sbdev->is_laddr_valid = true; sbdev->is_laddr_valid = true;
mutex_unlock(&ctrl->lock);
slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP);
@@ -473,6 +474,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev,
laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code, laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code,
sbdev->e_addr.dev_index, sbdev->e_addr.instance); sbdev->e_addr.dev_index, sbdev->e_addr.instance);
return 0;
err: err:
mutex_unlock(&ctrl->lock); mutex_unlock(&ctrl->lock);
return ret; return ret;