leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: qualcomm: rmnet: Remove the rmnet_map_results enum

Browse Source 
Only the success and consumed entries were actually in use.
Use standard error codes instead.

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Subash Abhinov Kasiviswanathan 2017-12-11 17:30:10 -07:00 committed by David S. Miller
parent b4f70c3d4e
commit cf2fe57b0c
2 changed files with 3 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
View File

@ -142,11 +142,11 @@ static int rmnet_map_egress_handler(struct sk_buff *skb,
skb->protocol = htons(ETH_P_MAP); skb->protocol = htons(ETH_P_MAP);
return RMNET_MAP_SUCCESS; return 0;
fail: fail:
kfree_skb(skb); kfree_skb(skb);
return RMNET_MAP_CONSUMED; return -ENOMEM;
} }
static void static void
@ -213,17 +213,8 @@ void rmnet_egress_handler(struct sk_buff *skb)
} }
if (port->egress_data_format & RMNET_EGRESS_FORMAT_MAP) { if (port->egress_data_format & RMNET_EGRESS_FORMAT_MAP) {
switch (rmnet_map_egress_handler(skb, port, mux_id, orig_dev)) { if (rmnet_map_egress_handler(skb, port, mux_id, orig_dev))
case RMNET_MAP_CONSUMED:
return; return;
case RMNET_MAP_SUCCESS:
break;
default:
kfree_skb(skb);
return;
}
} }
rmnet_vnd_tx_fixup(skb, orig_dev); rmnet_vnd_tx_fixup(skb, orig_dev);

9
drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h
View File

@ -30,15 +30,6 @@ struct rmnet_map_control_command {
}; };
} __aligned(1); } __aligned(1);
enum rmnet_map_results {
RMNET_MAP_SUCCESS,
RMNET_MAP_CONSUMED,
RMNET_MAP_GENERAL_FAILURE,
RMNET_MAP_NOT_ENABLED,
RMNET_MAP_FAILED_AGGREGATION,
RMNET_MAP_FAILED_MUX
};
enum rmnet_map_commands { enum rmnet_map_commands {
RMNET_MAP_COMMAND_NONE, RMNET_MAP_COMMAND_NONE,
RMNET_MAP_COMMAND_FLOW_DISABLE, RMNET_MAP_COMMAND_FLOW_DISABLE,