leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

leaking_addresses: Always print a trailing newline

Browse Source 
For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.

Unconditionally remove the newline on input, and write it back out on
output.

[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20211008111626.151570317@infradead.org
This commit is contained in:
Kees Cook 2021-09-29 15:02:18 -07:00 committed by Peter Zijlstra
parent 54354c6a9f
commit cf2a85efda
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/leaking_addresses.pl
View File

@ -455,8 +455,9 @@ sub parse_file
open my $fh, "<", $file or return; open my $fh, "<", $file or return;
while ( <$fh> ) { while ( <$fh> ) {
chomp;
if (may_leak_address($_)) { if (may_leak_address($_)) {
print $file . ': ' . $_; printf("$file: $_\n");
} }
} }
close $fh; close $fh;