leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: dgap: fix "if" statement that always evaluates to true

Browse Source 
cppcheck warning:
(warnning) Logical disjunction always evaluates to true

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Daeseok Youn 2015-01-23 20:44:28 +09:00 committed by Greg Kroah-Hartman
parent ed2084360d
commit ce5b615bc2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/dgap/dgap.c
View File

@ -978,8 +978,8 @@ static int dgap_parsefile(char **in)
brd->u.board.conc1++;
conc_type = dgap_gettok(in);
if (conc_type == 0 || conc_type != CX ||
conc_type != EPC) {
if (conc_type == 0 || (conc_type != CX &&
conc_type != EPC)) {
pr_err("failed to set a type of concentratros");
return -1;
}
@ -1019,8 +1019,8 @@ static int dgap_parsefile(char **in)
brd->u.board.module1++;
module_type = dgap_gettok(in);
if (module_type == 0 || module_type != PORTS ||
module_type != MODEM) {
if (module_type == 0 || (module_type != PORTS &&
module_type != MODEM)) {
pr_err("failed to set a type of module");
return -1;
}