leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

orinoco: Remove BUG_ON(in_interrupt/irq())

Browse Source 
The usage of in_irq()/in_interrupt() in drivers is phased out and the
BUG_ON()'s based on those are not covering all contexts in which these
functions cannot be called.

Aside of that BUG_ON() should only be used as last resort, which is clearly
not the case here.

A broad variety of checks in the invoked functions (always enabled or debug
option dependent) cover these conditions already, so the BUG_ON()'s do not
really provide additional value.

Just remove them.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201101211536.2966644-2-bigeasy@linutronix.de
This commit is contained in:
Sebastian Andrzej Siewior 2020-11-01 22:15:29 +01:00 committed by Kalle Valo
parent 2860615076
commit ce4dd05cbb
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/intersil/orinoco/orinoco_usb.c
View File

@ -859,8 +859,6 @@ static int ezusb_access_ltv(struct ezusb_priv *upriv,
int retval = 0; int retval = 0;
enum ezusb_state state; enum ezusb_state state;
BUG_ON(in_irq());
if (!upriv->udev) { if (!upriv->udev) {
retval = -ENODEV; retval = -ENODEV;
goto exit; goto exit;
@ -1349,7 +1347,6 @@ static int ezusb_init(struct hermes *hw)
struct ezusb_priv *upriv = hw->priv; struct ezusb_priv *upriv = hw->priv;
int retval; int retval;
BUG_ON(in_interrupt());
if (!upriv) if (!upriv)
return -EINVAL; return -EINVAL;
@ -1448,7 +1445,6 @@ static inline void ezusb_delete(struct ezusb_priv *upriv)
struct list_head *tmp_item; struct list_head *tmp_item;
unsigned long flags; unsigned long flags;
BUG_ON(in_interrupt());
BUG_ON(!upriv); BUG_ON(!upriv);
mutex_lock(&upriv->mtx); mutex_lock(&upriv->mtx);