leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

isci: task.h compile and checkpatch fixes

Browse Source 
A usage of "FALSE" leaked in as well as some checkpatch escapes.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams 2011-03-17 08:04:43 -07:00
parent c4b9e24c4b
commit ce0b89f356
1 changed files with 19 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
drivers/scsi/isci/task.h
View File

@ -306,7 +306,6 @@ isci_task_set_completion_status(
* is in the error path. * is in the error path.
*/ */
if (task->task_state_flags & SAS_TASK_NEED_DEV_RESET) { if (task->task_state_flags & SAS_TASK_NEED_DEV_RESET) {
/* Fail the I/O to make sure it goes into the error path. */ /* Fail the I/O to make sure it goes into the error path. */
response = SAS_TASK_UNDELIVERED; response = SAS_TASK_UNDELIVERED;
status = SAM_STAT_TASK_ABORTED; status = SAM_STAT_TASK_ABORTED;
@ -317,28 +316,25 @@ isci_task_set_completion_status(
task->task_status.stat = status; task->task_status.stat = status;
switch (task_notification_selection) { switch (task_notification_selection) {
case isci_perform_aborted_io_completion:
case isci_perform_aborted_io_completion: /* This path can occur with task-managed requests as well as
/* This path can occur with task-managed requests as well as * requests terminated because of LUN or device resets.
* requests terminated because of LUN or device resets. */
*/ /* Fall through to the normal case... */
/* Fall through to the normal case... */ case isci_perform_normal_io_completion:
/* Normal notification (task_done) */
case isci_perform_normal_io_completion: isci_set_task_doneflags(task);
/* Normal notification (task_done) */ break;
isci_set_task_doneflags(task); default:
break; WARN_ONCE(1, "unknown task_notification_selection: %d\n",
task_notification_selection);
default: /* Fall through to the error case... */
WARN_ON(FALSE); case isci_perform_error_io_completion:
/* Fall through to the error case... */ /* Use sas_task_abort */
/* Leave SAS_TASK_STATE_DONE clear
case isci_perform_error_io_completion: * Leave SAS_TASK_AT_INITIATOR set.
/* Use sas_task_abort */ */
/* Leave SAS_TASK_STATE_DONE clear break;
* Leave SAS_TASK_AT_INITIATOR set.
*/
break;
} }
spin_unlock_irqrestore(&task->task_state_lock, flags); spin_unlock_irqrestore(&task->task_state_lock, flags);