leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi: pxa2xx: Drop duplicate chip_select in struct chip_data

Browse Source 
The struct chip_data had been introduced in order to keep the parameters
that may be provided on stack during device allocation. There is no need
to duplicate parameters there, which are carried on by SPI device itself.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210517140351.901-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Andy Shevchenko 2021-05-17 17:03:46 +03:00 committed by Mark Brown
parent de6926f307
commit ccd60b2030
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-pxa2xx.c
View File

@ -432,7 +432,7 @@ static void cs_assert(struct spi_device *spi)
spi_controller_get_devdata(spi->controller);
if (drv_data->ssp_type == CE4100_SSP) {
pxa2xx_spi_write(drv_data, SSSR, chip->frm);
pxa2xx_spi_write(drv_data, SSSR, spi->chip_select);
return;
}
@ -1303,8 +1303,6 @@ static int setup(struct spi_device *spi)
kfree(chip);
return -EINVAL;
}
chip->frm = spi->chip_select;
}
chip->enable_dma = drv_data->controller_info->enable_dma;
chip->timeout = TIMOUT_DFLT;

1
drivers/spi/spi-pxa2xx.h
View File

@ -72,7 +72,6 @@ struct chip_data {
int (*write)(struct driver_data *drv_data);
int (*read)(struct driver_data *drv_data);
unsigned int frm;
void (*cs_control)(u32 command);
};