leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

kconfig: qconf: remove unused argument from ConfigList::updateList()

Browse Source 
This function allocates 'item' before using it, so the argument 'item'
is always shadowed.

Remove the meaningless argument.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada
2020-08-07 18:18:59 +09:00
parent 92641154bf
commit cb77043f06
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/kconfig/qconf.cc
View File

@@ -404,15 +404,15 @@ void ConfigList::updateSelection(void)
emit menuSelected(menu); emit menuSelected(menu);
} }
void ConfigList::updateList(ConfigItem* item) void ConfigList::updateList()
{ {
ConfigItem* last = 0; ConfigItem* last = 0;
ConfigItem *item;
if (!rootEntry) { if (!rootEntry) {
if (mode != listMode) if (mode != listMode)
goto update; goto update;
QTreeWidgetItemIterator it(this); QTreeWidgetItemIterator it(this);
ConfigItem* item;
while (*it) { while (*it) {
item = (ConfigItem*)(*it); item = (ConfigItem*)(*it);
@@ -990,7 +990,7 @@ void ConfigView::updateList(ConfigItem* item)
ConfigView* v; ConfigView* v;
for (v = viewList; v; v = v->nextView) for (v = viewList; v; v = v->nextView)
v->list->updateList(item); v->list->updateList();
} }
void ConfigView::updateListAll(void) void ConfigView::updateListAll(void)

4
scripts/kconfig/qconf.h
View File

@@ -69,7 +69,7 @@ protected:
public slots: public slots:
void setRootMenu(struct menu *menu); void setRootMenu(struct menu *menu);
void updateList(ConfigItem *item); void updateList();
void setValue(ConfigItem* item, tristate val); void setValue(ConfigItem* item, tristate val);
void changeValue(ConfigItem* item); void changeValue(ConfigItem* item);
void updateSelection(void); void updateSelection(void);
@@ -85,7 +85,7 @@ public:
void updateListAll(void) void updateListAll(void)
{ {
updateAll = true; updateAll = true;
updateList(NULL); updateList();
updateAll = false; updateAll = false;
} }
void addColumn(colIdx idx) void addColumn(colIdx idx)