leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

USB: serial: visor: fix crash on detecting device without write_urbs

Browse Source 
The visor driver crashes in clie_5_attach() when a specially crafted USB
device without bulk-out endpoint is detected. This fix adds a check that
the device has proper configuration expected by the driver.

Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Fixes: cfb8da8f69 ("USB: visor: fix initialisation of UX50/TH55 devices")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Vladis Dronov 2016-01-12 15:10:50 +01:00 committed by Johan Hovold
parent cac9b50b0d
commit cb3232138e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/serial/visor.c
View File

@ -602,8 +602,10 @@ static int clie_5_attach(struct usb_serial *serial)
*/ */
/* some sanity check */ /* some sanity check */
if (serial->num_ports < 2) if (serial->num_bulk_out < 2) {
return -1; dev_err(&serial->interface->dev, "missing bulk out endpoints\n");
return -ENODEV;
}
/* port 0 now uses the modified endpoint Address */ /* port 0 now uses the modified endpoint Address */
port = serial->port[0]; port = serial->port[0];