leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/msm/gpu: Don't allow zero fence_id

Browse Source 
Elsewhere we treat zero as "no fence" and __msm_gem_submit_destroy()
skips removal from fence_idr.  We could alternately change this to use
negative values for "no fence" but I think it is more clear to not allow
zero as a valid fence_id.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Fixes: a61acbbe9c ("drm/msm: Track "seqno" fences by idr")
Link: https://lore.kernel.org/r/20211129182344.292609-1-robdclark@gmail.com
Signed-off-by: Rob Clark <robdclark@chromium.org>
This commit is contained in:
Rob Clark
2021-11-29 10:23:44 -08:00
parent b9c8accbdd
commit ca3ffcbeb0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/msm/msm_gem_submit.c
View File

@@ -881,7 +881,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
* to the underlying fence. * to the underlying fence.
*/ */
submit->fence_id = idr_alloc_cyclic(&queue->fence_idr, submit->fence_id = idr_alloc_cyclic(&queue->fence_idr,
submit->user_fence, 0, INT_MAX, GFP_KERNEL); submit->user_fence, 1, INT_MAX, GFP_KERNEL);
if (submit->fence_id < 0) { if (submit->fence_id < 0) {
ret = submit->fence_id = 0; ret = submit->fence_id = 0;
submit->fence_id = 0; submit->fence_id = 0;