leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

crypto: inside-secure - avoid unmapping DMA memory that was not mapped

Browse Source 
This patch adds a parameter in the SafeXcel ahash request structure to
keep track of the number of SG entries mapped. This allows not to call
dma_unmap_sg() when dma_map_sg() wasn't called in the first place. This
also removes a warning when the debugging of the DMA-API is enabled in
the kernel configuration: "DMA-API: device driver tries to free DMA
memory it has not allocated".

Cc: stable@vger.kernel.org
Fixes: 1b44c5a60c ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Antoine Ténart 2017-12-26 17:21:16 +01:00 committed by Herbert Xu
parent 0b5a7f71b4
commit c957f8b3e2
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/crypto/inside-secure/safexcel_hash.c
View File

@ -33,6 +33,8 @@ struct safexcel_ahash_req {
bool hmac; bool hmac;
bool needs_inv; bool needs_inv;
int nents;
u8 state_sz; /* expected sate size, only set once */ u8 state_sz; /* expected sate size, only set once */
u32 state[SHA256_DIGEST_SIZE / sizeof(u32)] __aligned(sizeof(u32)); u32 state[SHA256_DIGEST_SIZE / sizeof(u32)] __aligned(sizeof(u32));
@ -151,8 +153,10 @@ static int safexcel_handle_req_result(struct safexcel_crypto_priv *priv, int rin
memcpy(areq->result, sreq->state, memcpy(areq->result, sreq->state,
crypto_ahash_digestsize(ahash)); crypto_ahash_digestsize(ahash));
dma_unmap_sg(priv->dev, areq->src, if (sreq->nents) {
sg_nents_for_len(areq->src, areq->nbytes), DMA_TO_DEVICE); dma_unmap_sg(priv->dev, areq->src, sreq->nents, DMA_TO_DEVICE);
sreq->nents = 0;
}
safexcel_free_context(priv, async, sreq->state_sz); safexcel_free_context(priv, async, sreq->state_sz);
@ -177,7 +181,7 @@ static int safexcel_ahash_send_req(struct crypto_async_request *async, int ring,
struct safexcel_command_desc *cdesc, *first_cdesc = NULL; struct safexcel_command_desc *cdesc, *first_cdesc = NULL;
struct safexcel_result_desc *rdesc; struct safexcel_result_desc *rdesc;
struct scatterlist *sg; struct scatterlist *sg;
int i, nents, queued, len, cache_len, extra, n_cdesc = 0, ret = 0; int i, queued, len, cache_len, extra, n_cdesc = 0, ret = 0;
queued = len = req->len - req->processed; queued = len = req->len - req->processed;
if (queued < crypto_ahash_blocksize(ahash)) if (queued < crypto_ahash_blocksize(ahash))
@ -233,15 +237,15 @@ static int safexcel_ahash_send_req(struct crypto_async_request *async, int ring,
} }
/* Now handle the current ahash request buffer(s) */ /* Now handle the current ahash request buffer(s) */
nents = dma_map_sg(priv->dev, areq->src, req->nents = dma_map_sg(priv->dev, areq->src,
sg_nents_for_len(areq->src, areq->nbytes), sg_nents_for_len(areq->src, areq->nbytes),
DMA_TO_DEVICE); DMA_TO_DEVICE);
if (!nents) { if (!req->nents) {
ret = -ENOMEM; ret = -ENOMEM;
goto cdesc_rollback; goto cdesc_rollback;
} }
for_each_sg(areq->src, sg, nents, i) { for_each_sg(areq->src, sg, req->nents, i) {
int sglen = sg_dma_len(sg); int sglen = sg_dma_len(sg);
/* Do not overflow the request */ /* Do not overflow the request */