drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote others
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483: warning: Function parameter or member 'new_state' not described in 'vmw_du_cursor_plane_atomic_check' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483: warning: Excess function parameter 'state' description in 'vmw_du_cursor_plane_atomic_check' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1069: warning: Function parameter or member 'vfb' not described in 'vmw_framebuffer_pin' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1281: warning: Function parameter or member 'dev_priv' not described in 'vmw_kms_srf_ok' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1907: warning: Function parameter or member 'crtc' not described in 'vmw_get_vblank_counter' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1915: warning: Function parameter or member 'crtc' not described in 'vmw_enable_vblank' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1923: warning: Function parameter or member 'crtc' not described in 'vmw_disable_vblank' drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:2131: warning: Function parameter or member 'mode' not described in 'vmw_guess_mode_timing' Cc: VMware Graphics <linux-graphics-maintainer@vmware.com> Cc: Roland Scheidegger <sroland@vmware.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Zack Rusin <zackr@vmware.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-21-lee.jones@linaro.org
This commit is contained in:
@@ -467,7 +467,7 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane *plane,
|
|||||||
* vmw_du_cursor_plane_atomic_check - check if the new state is okay
|
* vmw_du_cursor_plane_atomic_check - check if the new state is okay
|
||||||
*
|
*
|
||||||
* @plane: cursor plane
|
* @plane: cursor plane
|
||||||
* @state: info on the new plane state
|
* @new_state: info on the new plane state
|
||||||
*
|
*
|
||||||
* This is a chance to fail if the new cursor state does not fit
|
* This is a chance to fail if the new cursor state does not fit
|
||||||
* our requirements.
|
* our requirements.
|
||||||
@@ -1057,7 +1057,7 @@ static const struct drm_framebuffer_funcs vmw_framebuffer_bo_funcs = {
|
|||||||
.dirty = vmw_framebuffer_bo_dirty_ext,
|
.dirty = vmw_framebuffer_bo_dirty_ext,
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/*
|
||||||
* Pin the bofer in a location suitable for access by the
|
* Pin the bofer in a location suitable for access by the
|
||||||
* display system.
|
* display system.
|
||||||
*/
|
*/
|
||||||
@@ -1267,6 +1267,7 @@ out_err1:
|
|||||||
/**
|
/**
|
||||||
* vmw_kms_srf_ok - check if a surface can be created
|
* vmw_kms_srf_ok - check if a surface can be created
|
||||||
*
|
*
|
||||||
|
* @dev_priv: Pointer to device private struct.
|
||||||
* @width: requested width
|
* @width: requested width
|
||||||
* @height: requested height
|
* @height: requested height
|
||||||
*
|
*
|
||||||
@@ -1896,7 +1897,7 @@ bool vmw_kms_validate_mode_vram(struct vmw_private *dev_priv,
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
/**
|
/*
|
||||||
* Function called by DRM code called with vbl_lock held.
|
* Function called by DRM code called with vbl_lock held.
|
||||||
*/
|
*/
|
||||||
u32 vmw_get_vblank_counter(struct drm_crtc *crtc)
|
u32 vmw_get_vblank_counter(struct drm_crtc *crtc)
|
||||||
@@ -1904,7 +1905,7 @@ u32 vmw_get_vblank_counter(struct drm_crtc *crtc)
|
|||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/*
|
||||||
* Function called by DRM code called with vbl_lock held.
|
* Function called by DRM code called with vbl_lock held.
|
||||||
*/
|
*/
|
||||||
int vmw_enable_vblank(struct drm_crtc *crtc)
|
int vmw_enable_vblank(struct drm_crtc *crtc)
|
||||||
@@ -1912,7 +1913,7 @@ int vmw_enable_vblank(struct drm_crtc *crtc)
|
|||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/*
|
||||||
* Function called by DRM code called with vbl_lock held.
|
* Function called by DRM code called with vbl_lock held.
|
||||||
*/
|
*/
|
||||||
void vmw_disable_vblank(struct drm_crtc *crtc)
|
void vmw_disable_vblank(struct drm_crtc *crtc)
|
||||||
@@ -2120,7 +2121,7 @@ static struct drm_display_mode vmw_kms_connector_builtin[] = {
|
|||||||
* vmw_guess_mode_timing - Provide fake timings for a
|
* vmw_guess_mode_timing - Provide fake timings for a
|
||||||
* 60Hz vrefresh mode.
|
* 60Hz vrefresh mode.
|
||||||
*
|
*
|
||||||
* @mode - Pointer to a struct drm_display_mode with hdisplay and vdisplay
|
* @mode: Pointer to a struct drm_display_mode with hdisplay and vdisplay
|
||||||
* members filled in.
|
* members filled in.
|
||||||
*/
|
*/
|
||||||
void vmw_guess_mode_timing(struct drm_display_mode *mode)
|
void vmw_guess_mode_timing(struct drm_display_mode *mode)
|
||||||
|
|||||||
Reference in New Issue
Block a user