leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ath9k: remove unnecessary debugfs return code checks

Browse Source 
Since the ath9k debugfs directory is cleaned up by debugfs_remove_recursive,
there's no point in checking the return code of every single debugfs create
line.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Felix Fietkau 2011-03-19 13:55:37 +01:00 committed by John W. Linville
parent 716b1bf3c5
commit c70cab1a45
1 changed files with 29 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

88
drivers/net/wireless/ath/ath9k/debug.c
View File

@ -1088,67 +1088,37 @@ int ath9k_init_debug(struct ath_hw *ah)
return -ENOMEM; return -ENOMEM;
#ifdef CONFIG_ATH_DEBUG #ifdef CONFIG_ATH_DEBUG
if (!debugfs_create_file("debug", S_IRUSR | S_IWUSR, debugfs_create_file("debug", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
sc->debug.debugfs_phy, sc, &fops_debug)) sc, &fops_debug);
goto err;
#endif #endif
debugfs_create_file("dma", S_IRUSR, sc->debug.debugfs_phy, sc,
if (!debugfs_create_file("dma", S_IRUSR, sc->debug.debugfs_phy, &fops_dma);
sc, &fops_dma)) debugfs_create_file("interrupt", S_IRUSR, sc->debug.debugfs_phy, sc,
goto err; &fops_interrupt);
debugfs_create_file("wiphy", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
if (!debugfs_create_file("interrupt", S_IRUSR, sc->debug.debugfs_phy, sc, &fops_wiphy);
sc, &fops_interrupt)) debugfs_create_file("xmit", S_IRUSR, sc->debug.debugfs_phy, sc,
goto err; &fops_xmit);
debugfs_create_file("stations", S_IRUSR, sc->debug.debugfs_phy, sc,
if (!debugfs_create_file("wiphy", S_IRUSR | S_IWUSR, &fops_stations);
sc->debug.debugfs_phy, sc, &fops_wiphy)) debugfs_create_file("misc", S_IRUSR, sc->debug.debugfs_phy, sc,
goto err; &fops_misc);
debugfs_create_file("recv", S_IRUSR, sc->debug.debugfs_phy, sc,
if (!debugfs_create_file("xmit", S_IRUSR, sc->debug.debugfs_phy, &fops_recv);
sc, &fops_xmit)) debugfs_create_file("rx_chainmask", S_IRUSR | S_IWUSR,
goto err; sc->debug.debugfs_phy, sc, &fops_rx_chainmask);
debugfs_create_file("tx_chainmask", S_IRUSR | S_IWUSR,
if (!debugfs_create_file("stations", S_IRUSR, sc->debug.debugfs_phy, sc->debug.debugfs_phy, sc, &fops_tx_chainmask);
sc, &fops_stations)) debugfs_create_file("regidx", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
goto err; sc, &fops_regidx);
debugfs_create_file("regval", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
if (!debugfs_create_file("misc", S_IRUSR, sc->debug.debugfs_phy, sc, &fops_regval);
sc, &fops_misc)) debugfs_create_bool("ignore_extcca", S_IRUSR | S_IWUSR,
goto err; sc->debug.debugfs_phy,
&ah->config.cwm_ignore_extcca);
if (!debugfs_create_file("recv", S_IRUSR, sc->debug.debugfs_phy, debugfs_create_file("regdump", S_IRUSR, sc->debug.debugfs_phy, sc,
sc, &fops_recv)) &fops_regdump);
goto err;
if (!debugfs_create_file("rx_chainmask", S_IRUSR | S_IWUSR,
sc->debug.debugfs_phy, sc, &fops_rx_chainmask))
goto err;
if (!debugfs_create_file("tx_chainmask", S_IRUSR | S_IWUSR,
sc->debug.debugfs_phy, sc, &fops_tx_chainmask))
goto err;
if (!debugfs_create_file("regidx", S_IRUSR | S_IWUSR,
sc->debug.debugfs_phy, sc, &fops_regidx))
goto err;
if (!debugfs_create_file("regval", S_IRUSR | S_IWUSR,
sc->debug.debugfs_phy, sc, &fops_regval))
goto err;
if (!debugfs_create_bool("ignore_extcca", S_IRUSR | S_IWUSR,
sc->debug.debugfs_phy, &ah->config.cwm_ignore_extcca))
goto err;
if (!debugfs_create_file("regdump", S_IRUSR, sc->debug.debugfs_phy,
sc, &fops_regdump))
goto err;
sc->debug.regidx = 0; sc->debug.regidx = 0;
return 0; return 0;
err:
debugfs_remove_recursive(sc->debug.debugfs_phy);
sc->debug.debugfs_phy = NULL;
return -ENOMEM;
} }