leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PCI: dwc: artpec6: Fix return value check in artpec6_add_pcie_ep()

Browse Source 
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
This commit is contained in:
Wei Yongjun 2018-01-03 07:33:35 +00:00 committed by Lorenzo Pieralisi
parent 83f4f3f63b
commit c68febfd68
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/dwc/pcie-artpec6.c
View File

@ -485,8 +485,8 @@ static int artpec6_add_pcie_ep(struct artpec6_pcie *artpec6_pcie,
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2"); res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi2");
pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res)); pci->dbi_base2 = devm_ioremap(dev, res->start, resource_size(res));
if (IS_ERR(pci->dbi_base2)) if (!pci->dbi_base2)
return PTR_ERR(pci->dbi_base2); return -ENOMEM;
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space"); res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
if (!res) if (!res)