vfio: simplify iommu group allocation for mediated devices
Reuse the logic in vfio_noiommu_group_alloc to allocate a fake single-device iommu group for mediated devices by factoring out a common function, and replacing the noiommu boolean field in struct vfio_group with an enum to distinguish the three different kinds of groups. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Link: https://lore.kernel.org/r/20210924155705.4258-8-hch@lst.de Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
committed by
Alex Williamson
parent
c04ac34078
commit
c68ea0d00a
@@ -13,60 +13,23 @@
|
||||
|
||||
#include "mdev_private.h"
|
||||
|
||||
static int mdev_attach_iommu(struct mdev_device *mdev)
|
||||
{
|
||||
int ret;
|
||||
struct iommu_group *group;
|
||||
|
||||
group = iommu_group_alloc();
|
||||
if (IS_ERR(group))
|
||||
return PTR_ERR(group);
|
||||
|
||||
ret = iommu_group_add_device(group, &mdev->dev);
|
||||
if (!ret)
|
||||
dev_info(&mdev->dev, "MDEV: group_id = %d\n",
|
||||
iommu_group_id(group));
|
||||
|
||||
iommu_group_put(group);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static void mdev_detach_iommu(struct mdev_device *mdev)
|
||||
{
|
||||
iommu_group_remove_device(&mdev->dev);
|
||||
dev_info(&mdev->dev, "MDEV: detaching iommu\n");
|
||||
}
|
||||
|
||||
static int mdev_probe(struct device *dev)
|
||||
{
|
||||
struct mdev_driver *drv =
|
||||
container_of(dev->driver, struct mdev_driver, driver);
|
||||
struct mdev_device *mdev = to_mdev_device(dev);
|
||||
int ret;
|
||||
|
||||
ret = mdev_attach_iommu(mdev);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
if (drv->probe) {
|
||||
ret = drv->probe(mdev);
|
||||
if (ret)
|
||||
mdev_detach_iommu(mdev);
|
||||
}
|
||||
|
||||
return ret;
|
||||
if (!drv->probe)
|
||||
return 0;
|
||||
return drv->probe(to_mdev_device(dev));
|
||||
}
|
||||
|
||||
static void mdev_remove(struct device *dev)
|
||||
{
|
||||
struct mdev_driver *drv =
|
||||
container_of(dev->driver, struct mdev_driver, driver);
|
||||
struct mdev_device *mdev = to_mdev_device(dev);
|
||||
|
||||
if (drv->remove)
|
||||
drv->remove(mdev);
|
||||
|
||||
mdev_detach_iommu(mdev);
|
||||
drv->remove(to_mdev_device(dev));
|
||||
}
|
||||
|
||||
static int mdev_match(struct device *dev, struct device_driver *drv)
|
||||
|
||||
Reference in New Issue
Block a user