forked from Minki/linux
PCI: Use bitfield instead of bool for struct pci_vpd_pci22.busy
Make struct pci_vpd_pci22.busy a 1-bit field instead of a bool. We intend to add another flag, and two bitfields are cheaper than two bools. Tested-by: Shane Seymour <shane.seymour@hpe.com> Tested-by: Babu Moger <babu.moger@oracle.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Hannes Reinecke <hare@suse.com>
This commit is contained in:
parent
f52e5629f6
commit
c5563887a9
@ -283,8 +283,8 @@ struct pci_vpd_pci22 {
|
||||
struct pci_vpd base;
|
||||
struct mutex lock;
|
||||
u16 flag;
|
||||
bool busy;
|
||||
u8 cap;
|
||||
u8 busy:1;
|
||||
};
|
||||
|
||||
/*
|
||||
@ -313,7 +313,7 @@ static int pci_vpd_pci22_wait(struct pci_dev *dev)
|
||||
return ret;
|
||||
|
||||
if ((status & PCI_VPD_ADDR_F) == vpd->flag) {
|
||||
vpd->busy = false;
|
||||
vpd->busy = 0;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@ -355,7 +355,7 @@ static ssize_t pci_vpd_pci22_read(struct pci_dev *dev, loff_t pos, size_t count,
|
||||
pos & ~3);
|
||||
if (ret < 0)
|
||||
break;
|
||||
vpd->busy = true;
|
||||
vpd->busy = 1;
|
||||
vpd->flag = PCI_VPD_ADDR_F;
|
||||
ret = pci_vpd_pci22_wait(dev);
|
||||
if (ret < 0)
|
||||
@ -415,7 +415,7 @@ static ssize_t pci_vpd_pci22_write(struct pci_dev *dev, loff_t pos, size_t count
|
||||
if (ret < 0)
|
||||
break;
|
||||
|
||||
vpd->busy = true;
|
||||
vpd->busy = 1;
|
||||
vpd->flag = 0;
|
||||
ret = pci_vpd_pci22_wait(dev);
|
||||
if (ret < 0)
|
||||
@ -495,7 +495,7 @@ int pci_vpd_pci22_init(struct pci_dev *dev)
|
||||
vpd->base.ops = &pci_vpd_pci22_ops;
|
||||
mutex_init(&vpd->lock);
|
||||
vpd->cap = cap;
|
||||
vpd->busy = false;
|
||||
vpd->busy = 0;
|
||||
dev->vpd = &vpd->base;
|
||||
return 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user