leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mpt2sas: issue_reset is uninitialized

Browse Source 
The "issue_reset" variable can be used uninitialized.  It should be set
to false at the start.

Also I cleaned up the types by using bool.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Dan Carpenter 2014-12-04 13:56:10 +03:00 committed by Christoph Hellwig
parent 2195d96904
commit c51e3a4fc4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/scsi/mpt2sas/mpt2sas_base.c
View File

@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
u16 smid; u16 smid;
u32 ioc_state; u32 ioc_state;
unsigned long timeleft; unsigned long timeleft;
u8 issue_reset; bool issue_reset = false;
int rc; int rc;
void *request; void *request;
u16 wait_state_count; u16 wait_state_count;
@ -3300,7 +3300,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
_debug_dump_mf(mpi_request, _debug_dump_mf(mpi_request,
sizeof(Mpi2SasIoUnitControlRequest_t)/4); sizeof(Mpi2SasIoUnitControlRequest_t)/4);
if (!(ioc->base_cmds.status & MPT2_CMD_RESET)) if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
issue_reset = 1; issue_reset = true;
goto issue_host_reset; goto issue_host_reset;
} }
if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID) if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)
@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
u16 smid; u16 smid;
u32 ioc_state; u32 ioc_state;
unsigned long timeleft; unsigned long timeleft;
u8 issue_reset; bool issue_reset = false;
int rc; int rc;
void *request; void *request;
u16 wait_state_count; u16 wait_state_count;
@ -3398,7 +3398,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
_debug_dump_mf(mpi_request, _debug_dump_mf(mpi_request,
sizeof(Mpi2SepRequest_t)/4); sizeof(Mpi2SepRequest_t)/4);
if (!(ioc->base_cmds.status & MPT2_CMD_RESET)) if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
issue_reset = 1; issue_reset = true;
goto issue_host_reset; goto issue_host_reset;
} }
if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID) if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)