leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mtd: core: Potential NULL dereference in mtd_otp_size()

Browse Source 
If kmalloc() fails then it could lead to a NULL dereference.  Check and
return -ENOMEM on error.

Fixes: 4b361cfa86 ("mtd: core: add OTP nvmem provider support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/YJ6Iw3iNvGycAWV6@mwanda
This commit is contained in:
Dan Carpenter 2021-05-14 17:27:15 +03:00 committed by Miquel Raynal
parent bc8e157fdb
commit c3c8c051df
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mtd/mtdcore.c
View File

@ -779,12 +779,16 @@ static void mtd_set_dev_defaults(struct mtd_info *mtd)
static ssize_t mtd_otp_size(struct mtd_info *mtd, bool is_user) static ssize_t mtd_otp_size(struct mtd_info *mtd, bool is_user)
{ {
struct otp_info *info = kmalloc(PAGE_SIZE, GFP_KERNEL); struct otp_info *info;
ssize_t size = 0; ssize_t size = 0;
unsigned int i; unsigned int i;
size_t retlen; size_t retlen;
int ret; int ret;
info = kmalloc(PAGE_SIZE, GFP_KERNEL);
if (!info)
return -ENOMEM;
if (is_user) if (is_user)
ret = mtd_get_user_prot_info(mtd, PAGE_SIZE, &retlen, info); ret = mtd_get_user_prot_info(mtd, PAGE_SIZE, &retlen, info);
else else