leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pcie-gadget-spear: fix error return code in spear_pcie_gadget_probe()

Browse Source 
Fix to return a negative error code in the clk_get_sys() and clk_enable()
error handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2013-05-31 20:01:30 +08:00 committed by Greg Kroah-Hartman
parent fca597558e
commit c265a0d515
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/misc/spear13xx_pcie_gadget.c
View File

@ -814,9 +814,11 @@ static int spear_pcie_gadget_probe(struct platform_device *pdev)
clk = clk_get_sys("pcie1", NULL); clk = clk_get_sys("pcie1", NULL);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("%s:couldn't get clk for pcie1\n", __func__); pr_err("%s:couldn't get clk for pcie1\n", __func__);
status = PTR_ERR(clk);
goto err_irq; goto err_irq;
} }
if (clk_enable(clk)) { status = clk_enable(clk);
if (status) {
pr_err("%s:couldn't enable clk for pcie1\n", __func__); pr_err("%s:couldn't enable clk for pcie1\n", __func__);
goto err_irq; goto err_irq;
} }
@ -828,9 +830,11 @@ static int spear_pcie_gadget_probe(struct platform_device *pdev)
clk = clk_get_sys("pcie2", NULL); clk = clk_get_sys("pcie2", NULL);
if (IS_ERR(clk)) { if (IS_ERR(clk)) {
pr_err("%s:couldn't get clk for pcie2\n", __func__); pr_err("%s:couldn't get clk for pcie2\n", __func__);
status = PTR_ERR(clk);
goto err_irq; goto err_irq;
} }
if (clk_enable(clk)) { status = clk_enable(clk);
if (status) {
pr_err("%s:couldn't enable clk for pcie2\n", __func__); pr_err("%s:couldn't enable clk for pcie2\n", __func__);
goto err_irq; goto err_irq;
} }