forked from Minki/linux
cifsd: fix memory leak when loop ends
Memory is being allocated and if veto_list is zero, the loop breaks without cleaning up the allocated memory. In this patch, the length check has been moved before allocation. If loop breaks, the memory isn't allocated in the first place. Thus the memory is being protected from leaking. Reported-by: coverity-bot <keescook+coverity-bot@chromium.org> Addresses-Coverity-ID: 1503590 ("Resource leaks") Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
parent
5da64d8784
commit
c250e8f556
|
@ -92,14 +92,14 @@ static int parse_veto_list(struct ksmbd_share_config *share,
|
|||
while (veto_list_sz > 0) {
|
||||
struct ksmbd_veto_pattern *p;
|
||||
|
||||
p = kzalloc(sizeof(struct ksmbd_veto_pattern), GFP_KERNEL);
|
||||
if (!p)
|
||||
return -ENOMEM;
|
||||
|
||||
sz = strlen(veto_list);
|
||||
if (!sz)
|
||||
break;
|
||||
|
||||
p = kzalloc(sizeof(struct ksmbd_veto_pattern), GFP_KERNEL);
|
||||
if (!p)
|
||||
return -ENOMEM;
|
||||
|
||||
p->pattern = kstrdup(veto_list, GFP_KERNEL);
|
||||
if (!p->pattern) {
|
||||
ksmbd_free(p);
|
||||
|
|
Loading…
Reference in New Issue
Block a user