leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mm/migrate: Use a folio in migrate_misplaced_transhuge_page()

Browse Source 
Unify alloc_misplaced_dst_page() and alloc_misplaced_dst_page_thp().
Removes an assumption that compound pages are HPAGE_PMD_ORDER.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
This commit is contained in:
Matthew Wilcox (Oracle) 2021-07-06 10:50:39 -04:00
parent ffe06786b5
commit c185e494ae
1 changed files with 15 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
mm/migrate.c
View File

@ -1997,32 +1997,20 @@ static struct page *alloc_misplaced_dst_page(struct page *page,
unsigned long data) unsigned long data)
{ {
int nid = (int) data; int nid = (int) data;
struct page *newpage; int order = compound_order(page);
gfp_t gfp = __GFP_THISNODE;
struct folio *new;
newpage = __alloc_pages_node(nid, if (order > 0)
(GFP_HIGHUSER_MOVABLE | gfp |= GFP_TRANSHUGE_LIGHT;
__GFP_THISNODE | __GFP_NOMEMALLOC | else {
__GFP_NORETRY | __GFP_NOWARN) & gfp |= GFP_HIGHUSER_MOVABLE | __GFP_NOMEMALLOC | __GFP_NORETRY |
~__GFP_RECLAIM, 0); __GFP_NOWARN;
gfp &= ~__GFP_RECLAIM;
}
new = __folio_alloc_node(gfp, order, nid);
return newpage; return &new->page;
}
static struct page *alloc_misplaced_dst_page_thp(struct page *page,
unsigned long data)
{
int nid = (int) data;
struct page *newpage;
newpage = alloc_pages_node(nid, (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE),
HPAGE_PMD_ORDER);
if (!newpage)
goto out;
prep_transhuge_page(newpage);
out:
return newpage;
} }
static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
@ -2080,22 +2068,8 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
int nr_remaining; int nr_remaining;
unsigned int nr_succeeded; unsigned int nr_succeeded;
LIST_HEAD(migratepages); LIST_HEAD(migratepages);
new_page_t *new;
bool compound;
int nr_pages = thp_nr_pages(page); int nr_pages = thp_nr_pages(page);
/*
* PTE mapped THP or HugeTLB page can't reach here so the page could
* be either base page or THP. And it must be head page if it is
* THP.
*/
compound = PageTransHuge(page);
if (compound)
new = alloc_misplaced_dst_page_thp;
else
new = alloc_misplaced_dst_page;
/* /*
* Don't migrate file pages that are mapped in multiple processes * Don't migrate file pages that are mapped in multiple processes
* with execute permissions as they are probably shared libraries. * with execute permissions as they are probably shared libraries.
@ -2116,9 +2090,9 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
goto out; goto out;
list_add(&page->lru, &migratepages); list_add(&page->lru, &migratepages);
nr_remaining = migrate_pages(&migratepages, *new, NULL, node, nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_page,
MIGRATE_ASYNC, MR_NUMA_MISPLACED, NULL, node, MIGRATE_ASYNC,
&nr_succeeded); MR_NUMA_MISPLACED, &nr_succeeded);
if (nr_remaining) { if (nr_remaining) {
if (!list_empty(&migratepages)) { if (!list_empty(&migratepages)) {
list_del(&page->lru); list_del(&page->lru);