leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: aoa: Use device_type helpers to access the node type

Browse Source 
Remove directly accessing device_node.type pointer and use the accessors
instead. This will eventually allow removing the type pointer.

Replace the open coded iterating over child nodes with
for_each_child_of_node() while we're here.

Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: alsa-devel@alsa-project.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Rob Herring 2018-11-16 16:11:04 -06:00 committed by Takashi Iwai
parent 988e30af9a
commit c12faa2bc5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/aoa/fabrics/layout.c
View File

@ -1008,8 +1008,8 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev)
return -ENODEV; return -ENODEV;
/* by breaking out we keep a reference */ /* by breaking out we keep a reference */
while ((sound = of_get_next_child(sdev->ofdev.dev.of_node, sound))) { for_each_child_of_node(sdev->ofdev.dev.of_node, sound) {
if (sound->type && strcasecmp(sound->type, "soundchip") == 0) if (of_node_is_type(sound, "soundchip"))
break; break;
} }
if (!sound) if (!sound)

2
sound/aoa/soundbus/core.c
View File

@ -78,7 +78,7 @@ static int soundbus_uevent(struct device *dev, struct kobj_uevent_env *env)
if (retval) if (retval)
return retval; return retval;
retval = add_uevent_var(env, "OF_TYPE=%s", of->dev.of_node->type); retval = add_uevent_var(env, "OF_TYPE=%s", of_node_get_device_type(of->dev.of_node));
if (retval) if (retval)
return retval; return retval;