leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iommu/vt-d: Check return value of acpi_bus_get_device()

Browse Source 
Checking adev == NULL is not sufficient as
acpi_bus_get_device() might not touch the value of this
parameter in an error case, so check the return value
directly.

Fixes: ed40356b5f
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Joerg Roedel 2014-08-21 23:06:48 +02:00
parent c4a783b89e
commit c0df975f90
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/iommu/dmar.c
View File

@ -678,8 +678,7 @@ static int __init dmar_acpi_dev_scope_init(void)
andd->device_name); andd->device_name);
continue; continue;
} }
acpi_bus_get_device(h, &adev); if (acpi_bus_get_device(h, &adev)) {
if (!adev) {
pr_err("Failed to get device for ACPI object %s\n", pr_err("Failed to get device for ACPI object %s\n",
andd->device_name); andd->device_name);
continue; continue;