leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

e1000e: ICHx/PCHx LOMs should use LPLU setting in NVM when going to Sx

Browse Source 
When going to Sx with an ICHx/PCH device, the default Low Power Link Up
(LPLU, a.k.a. reverse auto-negotiation) behavior should be whatever is set
in the NVM.  However, the function e1000_suspend_workarounds_ich8lan()
called when going to Sx always enabled LPLU in all power states.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Bruce Allan 2011-12-16 00:46:38 +00:00 committed by Jeff Kirsher
parent 90b82984a4
commit c077a9065b
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/intel/e1000e/ich8lan.c
View File

@ -3698,9 +3698,10 @@ void e1000e_gig_downshift_workaround_ich8lan(struct e1000_hw *hw)
* *
* During S0 to Sx transition, it is possible the link remains at gig * During S0 to Sx transition, it is possible the link remains at gig
* instead of negotiating to a lower speed. Before going to Sx, set * instead of negotiating to a lower speed. Before going to Sx, set
* 'LPLU Enabled' and 'Gig Disable' to force link speed negotiation * 'Gig Disable' to force link speed negotiation to a lower speed based on
* to a lower speed. For PCH and newer parts, the OEM bits PHY register * the LPLU setting in the NVM or custom setting. For PCH and newer parts,
* (LED, GbE disable and LPLU configurations) also needs to be written. * the OEM bits PHY register (LED, GbE disable and LPLU configurations) also
* needs to be written.
**/ **/
void e1000_suspend_workarounds_ich8lan(struct e1000_hw *hw) void e1000_suspend_workarounds_ich8lan(struct e1000_hw *hw)
{ {
@ -3708,7 +3709,7 @@ void e1000_suspend_workarounds_ich8lan(struct e1000_hw *hw)
s32 ret_val; s32 ret_val;
phy_ctrl = er32(PHY_CTRL); phy_ctrl = er32(PHY_CTRL);
phy_ctrl |= E1000_PHY_CTRL_D0A_LPLU | E1000_PHY_CTRL_GBE_DISABLE; phy_ctrl |= E1000_PHY_CTRL_GBE_DISABLE;
ew32(PHY_CTRL, phy_ctrl); ew32(PHY_CTRL, phy_ctrl);
if (hw->mac.type == e1000_ich8lan) if (hw->mac.type == e1000_ich8lan)