leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: xen: remove unnecessary variable in xen_foreach_remap_area()

Browse Source 
Remove unnecessary variable mfn in function xen_foreach_remap_area() and,
refactor the code.

Variable mfn at line 518:mfn = xen_remap_buf.mfns[i];
is only being used to store a value to be passed as
an argument to the xen_update_mem_tables() function.
This value can be passed directly, which makes variable
mfn unnecessary. Also, value assigned to variable mfn
at line 534:mfn = xen_remap_mfn; is never used.

Addresses-Coverity-ID: 1260110
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
This commit is contained in:
Gustavo A. R. Silva 2017-06-23 17:01:20 -05:00 committed by Juergen Gross
parent a5d5f328b0
commit bf1b9ddf18
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/x86/xen/setup.c
View File

@ -499,7 +499,7 @@ static unsigned long __init xen_foreach_remap_area(unsigned long nr_pages,
void __init xen_remap_memory(void) void __init xen_remap_memory(void)
{ {
unsigned long buf = (unsigned long)&xen_remap_buf; unsigned long buf = (unsigned long)&xen_remap_buf;
unsigned long mfn_save, mfn, pfn; unsigned long mfn_save, pfn;
unsigned long remapped = 0; unsigned long remapped = 0;
unsigned int i; unsigned int i;
unsigned long pfn_s = ~0UL; unsigned long pfn_s = ~0UL;
@ -515,8 +515,7 @@ void __init xen_remap_memory(void)
pfn = xen_remap_buf.target_pfn; pfn = xen_remap_buf.target_pfn;
for (i = 0; i < xen_remap_buf.size; i++) { for (i = 0; i < xen_remap_buf.size; i++) {
mfn = xen_remap_buf.mfns[i]; xen_update_mem_tables(pfn, xen_remap_buf.mfns[i]);
xen_update_mem_tables(pfn, mfn);
remapped++; remapped++;
pfn++; pfn++;
} }
@ -530,8 +529,6 @@ void __init xen_remap_memory(void)
pfn_s = xen_remap_buf.target_pfn; pfn_s = xen_remap_buf.target_pfn;
len = xen_remap_buf.size; len = xen_remap_buf.size;
} }
mfn = xen_remap_mfn;
xen_remap_mfn = xen_remap_buf.next_area_mfn; xen_remap_mfn = xen_remap_buf.next_area_mfn;
} }