leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

et131x: use msecs_to_jiffies for conversions

Browse Source 
This is only an API consolidation and should make things more readable.
Converting milliseconds to jiffies by "val * HZ / 1000" is technically
OK but msecs_to_jiffies(val) is the cleaner solution and handles all
corner cases correctly. This is a minor API cleanup only.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nicholas Mc Guire 2015-02-11 04:27:54 -05:00 committed by David S. Miller
parent 777b3e930a
commit bc2f3873f7
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/agere/et131x.c
View File

@ -3127,7 +3127,8 @@ static void et131x_error_timer_handler(unsigned long data)
} }
/* This is a periodic timer, so reschedule */ /* This is a periodic timer, so reschedule */
mod_timer(&adapter->error_timer, jiffies + TX_ERROR_PERIOD * HZ / 1000); mod_timer(&adapter->error_timer, jiffies +
msecs_to_jiffies(TX_ERROR_PERIOD));
} }
static void et131x_adapter_memory_free(struct et131x_adapter *adapter) static void et131x_adapter_memory_free(struct et131x_adapter *adapter)
@ -3647,7 +3648,8 @@ static int et131x_open(struct net_device *netdev)
/* Start the timer to track NIC errors */ /* Start the timer to track NIC errors */
init_timer(&adapter->error_timer); init_timer(&adapter->error_timer);
adapter->error_timer.expires = jiffies + TX_ERROR_PERIOD * HZ / 1000; adapter->error_timer.expires = jiffies +
msecs_to_jiffies(TX_ERROR_PERIOD);
adapter->error_timer.function = et131x_error_timer_handler; adapter->error_timer.function = et131x_error_timer_handler;
adapter->error_timer.data = (unsigned long)adapter; adapter->error_timer.data = (unsigned long)adapter;
add_timer(&adapter->error_timer); add_timer(&adapter->error_timer);