leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390/qeth: modernize two list helpers

Browse Source 
Replace list_for_each() with list_for_each_entry(), and
list_entry(head.next) with list_first_entry().

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julian Wiedmann 2020-03-25 10:35:07 +01:00 committed by David S. Miller
parent c91a1fb7a4
commit bb59c8a89a
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/s390/net/qeth_core_main.c
View File

@ -2629,15 +2629,13 @@ static void qeth_initialize_working_pool_list(struct qeth_card *card)
static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry( static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry(
struct qeth_card *card) struct qeth_card *card)
{ {
struct list_head *plh;
struct qeth_buffer_pool_entry *entry; struct qeth_buffer_pool_entry *entry;
int i, free; int i, free;
if (list_empty(&card->qdio.in_buf_pool.entry_list)) if (list_empty(&card->qdio.in_buf_pool.entry_list))
return NULL; return NULL;
list_for_each(plh, &card->qdio.in_buf_pool.entry_list) { list_for_each_entry(entry, &card->qdio.in_buf_pool.entry_list, list) {
entry = list_entry(plh, struct qeth_buffer_pool_entry, list);
free = 1; free = 1;
for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) { for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
if (page_count(entry->elements[i]) > 1) { if (page_count(entry->elements[i]) > 1) {
@ -2652,8 +2650,8 @@ static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry(
} }
/* no free buffer in pool so take first one and swap pages */ /* no free buffer in pool so take first one and swap pages */
entry = list_entry(card->qdio.in_buf_pool.entry_list.next, entry = list_first_entry(&card->qdio.in_buf_pool.entry_list,
struct qeth_buffer_pool_entry, list); struct qeth_buffer_pool_entry, list);
for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) { for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
if (page_count(entry->elements[i]) > 1) { if (page_count(entry->elements[i]) > 1) {
struct page *page = dev_alloc_page(); struct page *page = dev_alloc_page();