leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf hists browser: The dso can be obtained from popup_action->ms.map->dso

Browse Source 
So no need to have a 'dso' member in 'popup_action', remove it as no
code is using it, already.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-76a6s0007slug0op0wkl6o8b@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2015-11-12 16:01:56 -03:00
parent fae00650f7
commit b7f294b58a
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/perf/ui/browsers/hists.c
View File

@ -1430,7 +1430,6 @@ close_file_and_continue:
struct popup_action { struct popup_action {
struct thread *thread; struct thread *thread;
struct dso *dso;
struct map_symbol ms; struct map_symbol ms;
int socket; int socket;
@ -1565,7 +1564,6 @@ add_dso_opt(struct hist_browser *browser, struct popup_action *act,
return 0; return 0;
act->ms.map = map; act->ms.map = map;
act->dso = map->dso;
act->fn = do_zoom_dso; act->fn = do_zoom_dso;
return 1; return 1;
} }
@ -1827,7 +1825,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
while (1) { while (1) {
struct thread *thread = NULL; struct thread *thread = NULL;
struct dso *dso = NULL;
struct map *map = NULL; struct map *map = NULL;
int choice = 0; int choice = 0;
int socked_id = -1; int socked_id = -1;
@ -1839,8 +1836,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
if (browser->he_selection != NULL) { if (browser->he_selection != NULL) {
thread = hist_browser__selected_thread(browser); thread = hist_browser__selected_thread(browser);
map = browser->selection->map; map = browser->selection->map;
if (map)
dso = map->dso;
socked_id = browser->he_selection->socket; socked_id = browser->he_selection->socket;
} }
switch (key) { switch (key) {
@ -1874,7 +1869,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
hist_browser__dump(browser); hist_browser__dump(browser);
continue; continue;
case 'd': case 'd':
actions->dso = dso;
actions->ms.map = map; actions->ms.map = map;
do_zoom_dso(browser, actions); do_zoom_dso(browser, actions);
continue; continue;