leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: lpfc: Fix miss of register read failure check

Browse Source 
Coverity flagged missing status check on register read that flags a
poisoned data return value.

Add checking of register read status.

Link: https://lore.kernel.org/r/20190922035906.10977-4-jsmart2021@gmail.com
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
James Smart 2019-09-21 20:58:49 -07:00 committed by Martin K. Petersen
parent 65a3df63e7
commit b7b95fb863
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/scsi/lpfc/lpfc_attr.c
View File

@ -1475,8 +1475,9 @@ lpfc_sli4_pdev_status_reg_wait(struct lpfc_hba *phba)
int i; int i;
msleep(100); msleep(100);
lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr, if (lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr,
&portstat_reg.word0); &portstat_reg.word0))
return -EIO;
/* verify if privileged for the request operation */ /* verify if privileged for the request operation */
if (!bf_get(lpfc_sliport_status_rn, &portstat_reg) && if (!bf_get(lpfc_sliport_status_rn, &portstat_reg) &&
@ -1486,8 +1487,9 @@ lpfc_sli4_pdev_status_reg_wait(struct lpfc_hba *phba)
/* wait for the SLI port firmware ready after firmware reset */ /* wait for the SLI port firmware ready after firmware reset */
for (i = 0; i < LPFC_FW_RESET_MAXIMUM_WAIT_10MS_CNT; i++) { for (i = 0; i < LPFC_FW_RESET_MAXIMUM_WAIT_10MS_CNT; i++) {
msleep(10); msleep(10);
lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr, if (lpfc_readl(phba->sli4_hba.u.if_type2.STATUSregaddr,
&portstat_reg.word0); &portstat_reg.word0))
continue;
if (!bf_get(lpfc_sliport_status_err, &portstat_reg)) if (!bf_get(lpfc_sliport_status_err, &portstat_reg))
continue; continue;
if (!bf_get(lpfc_sliport_status_rn, &portstat_reg)) if (!bf_get(lpfc_sliport_status_rn, &portstat_reg))