leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

can: peak_usb: pcan_usb_get_serial(): unconditionally assign serial_number

Browse Source 
The function serial_number is only called from one location with a
valid serial_number pointer. Remove not needed NULL pointer check.

Link: https://lore.kernel.org/r/20210406111622.1874957-10-mkl@pengutronix.de
Acked-by: Stephane Grosjean <s.grosjean@peak-system.com>
Tested-by: Stephane Grosjean <s.grosjean@peak-system.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Marc Kleine-Budde 2021-04-05 19:52:19 +02:00
parent 0a7d6cdf90
commit b7a29d35a9
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/can/usb/peak_usb/pcan_usb.c
View File

@ -367,8 +367,6 @@ static int pcan_usb_get_serial(struct peak_usb_device *dev, u32 *serial_number)
err = pcan_usb_wait_rsp(dev, PCAN_USB_CMD_SN, PCAN_USB_GET, args); err = pcan_usb_wait_rsp(dev, PCAN_USB_CMD_SN, PCAN_USB_GET, args);
if (err) if (err)
return err; return err;
if (serial_number)
*serial_number = le32_to_cpup((__le32 *)args); *serial_number = le32_to_cpup((__le32 *)args);
return 0; return 0;