leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PM / devfreq: Change time stats to 64-bit

Browse Source 
Change time stats counting to bigger type by using 64-bit jiffies.
This will make devfreq stats code look similar to cpufreq stats and
prevents overflow (for HZ = 1000 after 49.7 days).

Signed-off-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
Kamil Konieczny 2019-12-05 15:55:25 +01:00 committed by Chanwoo Choi
parent 2fee1a7cc6
commit b76b3479da
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/devfreq/devfreq.c
View File

@ -209,10 +209,10 @@ static int set_freq_table(struct devfreq *devfreq)
int devfreq_update_status(struct devfreq *devfreq, unsigned long freq) int devfreq_update_status(struct devfreq *devfreq, unsigned long freq)
{ {
int lev, prev_lev, ret = 0; int lev, prev_lev, ret = 0;
unsigned long cur_time; u64 cur_time;
lockdep_assert_held(&devfreq->lock); lockdep_assert_held(&devfreq->lock);
cur_time = jiffies; cur_time = get_jiffies_64();
/* Immediately exit if previous_freq is not initialized yet. */ /* Immediately exit if previous_freq is not initialized yet. */
if (!devfreq->previous_freq) if (!devfreq->previous_freq)
@ -535,7 +535,7 @@ void devfreq_monitor_resume(struct devfreq *devfreq)
msecs_to_jiffies(devfreq->profile->polling_ms)); msecs_to_jiffies(devfreq->profile->polling_ms));
out_update: out_update:
devfreq->last_stat_updated = jiffies; devfreq->last_stat_updated = get_jiffies_64();
devfreq->stop_polling = false; devfreq->stop_polling = false;
if (devfreq->profile->get_cur_freq && if (devfreq->profile->get_cur_freq &&
@ -820,7 +820,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
devfreq->time_in_state = devm_kcalloc(&devfreq->dev, devfreq->time_in_state = devm_kcalloc(&devfreq->dev,
devfreq->profile->max_state, devfreq->profile->max_state,
sizeof(unsigned long), sizeof(*devfreq->time_in_state),
GFP_KERNEL); GFP_KERNEL);
if (!devfreq->time_in_state) { if (!devfreq->time_in_state) {
mutex_unlock(&devfreq->lock); mutex_unlock(&devfreq->lock);
@ -828,7 +828,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
goto err_devfreq; goto err_devfreq;
} }
devfreq->last_stat_updated = jiffies; devfreq->last_stat_updated = get_jiffies_64();
srcu_init_notifier_head(&devfreq->transition_notifier_list); srcu_init_notifier_head(&devfreq->transition_notifier_list);
@ -1589,8 +1589,8 @@ static ssize_t trans_stat_show(struct device *dev,
for (j = 0; j < max_state; j++) for (j = 0; j < max_state; j++)
len += sprintf(buf + len, "%10u", len += sprintf(buf + len, "%10u",
devfreq->trans_table[(i * max_state) + j]); devfreq->trans_table[(i * max_state) + j]);
len += sprintf(buf + len, "%10u\n", len += sprintf(buf + len, "%10llu\n", (u64)
jiffies_to_msecs(devfreq->time_in_state[i])); jiffies64_to_msecs(devfreq->time_in_state[i]));
} }
len += sprintf(buf + len, "Total transition : %u\n", len += sprintf(buf + len, "Total transition : %u\n",

4
include/linux/devfreq.h
View File

@ -177,8 +177,8 @@ struct devfreq {
/* information for device frequency transition */ /* information for device frequency transition */
unsigned int total_trans; unsigned int total_trans;
unsigned int *trans_table; unsigned int *trans_table;
unsigned long *time_in_state; u64 *time_in_state;
unsigned long last_stat_updated; u64 last_stat_updated;
struct srcu_notifier_head transition_notifier_list; struct srcu_notifier_head transition_notifier_list;