leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch

Browse Source 
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() checks null pointer.

Fixes: ea35645a3c ("mmc: sdhci-of-esdhc: add support for signal voltage switch")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220523144255.10310-1-linmq006@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Miaoqian Lin 2022-05-23 18:42:54 +04:00 committed by Ulf Hansson
parent 97904a5985
commit b5899a3e2f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/mmc/host/sdhci-of-esdhc.c
View File

@ -904,6 +904,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc,
scfg_node = of_find_matching_node(NULL, scfg_device_ids); scfg_node = of_find_matching_node(NULL, scfg_device_ids);
if (scfg_node) if (scfg_node)
scfg_base = of_iomap(scfg_node, 0); scfg_base = of_iomap(scfg_node, 0);
of_node_put(scfg_node);
if (scfg_base) { if (scfg_base) {
sdhciovselcr = SDHCIOVSELCR_TGLEN | sdhciovselcr = SDHCIOVSELCR_TGLEN |
SDHCIOVSELCR_VSELVAL; SDHCIOVSELCR_VSELVAL;