leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net/mlx5e: Use refcount_t for refcount

Browse Source 
refcount_t is better for reference counters since its
implementation can prevent overflows.
So convert atomic_t ref counters to refcount_t.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
This commit is contained in:
Chuhong Yuan 2019-08-03 00:48:28 +08:00 committed by Saeed Mahameed
parent c938451f6b
commit b51c225e6c
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c
View File

@ -32,6 +32,7 @@
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/refcount.h>
#include <linux/mlx5/driver.h> #include <linux/mlx5/driver.h>
#include <net/vxlan.h> #include <net/vxlan.h>
#include "mlx5_core.h" #include "mlx5_core.h"
@ -48,7 +49,7 @@ struct mlx5_vxlan {
struct mlx5_vxlan_port { struct mlx5_vxlan_port {
struct hlist_node hlist; struct hlist_node hlist;
atomic_t refcount; refcount_t refcount;
u16 udp_port; u16 udp_port;
}; };
@ -113,7 +114,7 @@ int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port)
vxlanp = mlx5_vxlan_lookup_port(vxlan, port); vxlanp = mlx5_vxlan_lookup_port(vxlan, port);
if (vxlanp) { if (vxlanp) {
atomic_inc(&vxlanp->refcount); refcount_inc(&vxlanp->refcount);
return 0; return 0;
} }
@ -137,7 +138,7 @@ int mlx5_vxlan_add_port(struct mlx5_vxlan *vxlan, u16 port)
} }
vxlanp->udp_port = port; vxlanp->udp_port = port;
atomic_set(&vxlanp->refcount, 1); refcount_set(&vxlanp->refcount, 1);
spin_lock_bh(&vxlan->lock); spin_lock_bh(&vxlan->lock);
hash_add(vxlan->htable, &vxlanp->hlist, port); hash_add(vxlan->htable, &vxlanp->hlist, port);
@ -170,7 +171,7 @@ int mlx5_vxlan_del_port(struct mlx5_vxlan *vxlan, u16 port)
goto out_unlock; goto out_unlock;
} }
if (atomic_dec_and_test(&vxlanp->refcount)) { if (refcount_dec_and_test(&vxlanp->refcount)) {
hash_del(&vxlanp->hlist); hash_del(&vxlanp->hlist);
remove = true; remove = true;
} }