leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: prestera: flower: fix destroy tmpl in chain

Browse Source 
Fix flower destroy template callback to release template
only for specific tc chain instead of all chain tempaltes.

The issue was intruduced by previous commit that introduced
multi-chain support.

Fixes: fa5d824ce5 ("net: prestera: acl: add multi-chain support offload")
Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Volodymyr Mytnyk 2022-02-18 11:39:49 +02:00 committed by David S. Miller
parent 36a29fb6b2
commit b3ae2d350d
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/net/ethernet/marvell/prestera/prestera_flower.c
View File

@ -12,18 +12,21 @@ struct prestera_flower_template {
u32 chain_index;
};
static void
prestera_flower_template_free(struct prestera_flower_template *template)
{
prestera_acl_ruleset_put(template->ruleset);
list_del(&template->list);
kfree(template);
}
void prestera_flower_template_cleanup(struct prestera_flow_block *block)
{
struct prestera_flower_template *template;
struct list_head *pos, *n;
struct prestera_flower_template *template, *tmp;
/* put the reference to all rulesets kept in tmpl create */
list_for_each_safe(pos, n, &block->template_list) {
template = list_entry(pos, typeof(*template), list);
prestera_acl_ruleset_put(template->ruleset);
list_del(&template->list);
kfree(template);
}
list_for_each_entry_safe(template, tmp, &block->template_list, list)
prestera_flower_template_free(template);
}
static int
@ -423,7 +426,14 @@ err_malloc:
void prestera_flower_tmplt_destroy(struct prestera_flow_block *block,
struct flow_cls_offload *f)
{
prestera_flower_template_cleanup(block);
struct prestera_flower_template *template, *tmp;
list_for_each_entry_safe(template, tmp, &block->template_list, list)
if (template->chain_index == f->common.chain_index) {
/* put the reference to the ruleset kept in create */
prestera_flower_template_free(template);
return;
}
}
int prestera_flower_stats(struct prestera_flow_block *block,