leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

KVM: x86: Introduce cpuid_entry_{change,set,clear}() mutators

Browse Source 
Introduce mutators to modify feature bits in CPUID entries and use the
new mutators where applicable.  Using the mutators eliminates the need
to manually specify the register to modify query at no extra cost and
will allow adding runtime consistency checks on the function/index in a
future patch.

No functional change intended.

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Sean Christopherson 2020-03-02 15:56:31 -08:00 committed by Paolo Bonzini
parent 4c61534aaa
commit b32666b13a
3 changed files with 62 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
arch/x86/kvm/cpuid.c
View File

@ -57,15 +57,12 @@ int kvm_update_cpuid(struct kvm_vcpu *vcpu)
return 0; return 0;
/* Update OSXSAVE bit */ /* Update OSXSAVE bit */
if (boot_cpu_has(X86_FEATURE_XSAVE) && best->function == 0x1) { if (boot_cpu_has(X86_FEATURE_XSAVE) && best->function == 0x1)
best->ecx &= ~F(OSXSAVE); cpuid_entry_change(best, X86_FEATURE_OSXSAVE,
if (kvm_read_cr4_bits(vcpu, X86_CR4_OSXSAVE)) kvm_read_cr4_bits(vcpu, X86_CR4_OSXSAVE));
best->ecx |= F(OSXSAVE);
}
best->edx &= ~F(APIC); cpuid_entry_change(best, X86_FEATURE_APIC,
if (vcpu->arch.apic_base & MSR_IA32_APICBASE_ENABLE) vcpu->arch.apic_base & MSR_IA32_APICBASE_ENABLE);
best->edx |= F(APIC);
if (apic) { if (apic) {
if (cpuid_entry_has(best, X86_FEATURE_TSC_DEADLINE_TIMER)) if (cpuid_entry_has(best, X86_FEATURE_TSC_DEADLINE_TIMER))
@ -75,14 +72,9 @@ int kvm_update_cpuid(struct kvm_vcpu *vcpu)
} }
best = kvm_find_cpuid_entry(vcpu, 7, 0); best = kvm_find_cpuid_entry(vcpu, 7, 0);
if (best) { if (best && boot_cpu_has(X86_FEATURE_PKU) && best->function == 0x7)
/* Update OSPKE bit */ cpuid_entry_change(best, X86_FEATURE_OSPKE,
if (boot_cpu_has(X86_FEATURE_PKU) && best->function == 0x7) { kvm_read_cr4_bits(vcpu, X86_CR4_PKE));
best->ecx &= ~F(OSPKE);
if (kvm_read_cr4_bits(vcpu, X86_CR4_PKE))
best->ecx |= F(OSPKE);
}
}
best = kvm_find_cpuid_entry(vcpu, 0xD, 0); best = kvm_find_cpuid_entry(vcpu, 0xD, 0);
if (!best) { if (!best) {
@ -119,12 +111,10 @@ int kvm_update_cpuid(struct kvm_vcpu *vcpu)
if (!kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_MISC_ENABLE_NO_MWAIT)) { if (!kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_MISC_ENABLE_NO_MWAIT)) {
best = kvm_find_cpuid_entry(vcpu, 0x1, 0); best = kvm_find_cpuid_entry(vcpu, 0x1, 0);
if (best) { if (best)
if (vcpu->arch.ia32_misc_enable_msr & MSR_IA32_MISC_ENABLE_MWAIT) cpuid_entry_change(best, X86_FEATURE_MWAIT,
best->ecx |= F(MWAIT); vcpu->arch.ia32_misc_enable_msr &
else MSR_IA32_MISC_ENABLE_MWAIT);
best->ecx &= ~F(MWAIT);
}
} }
/* Update physical-address width */ /* Update physical-address width */
@ -157,7 +147,7 @@ static void cpuid_fix_nx_cap(struct kvm_vcpu *vcpu)
} }
} }
if (entry && cpuid_entry_has(entry, X86_FEATURE_NX) && !is_efer_nx()) { if (entry && cpuid_entry_has(entry, X86_FEATURE_NX) && !is_efer_nx()) {
entry->edx &= ~F(NX); cpuid_entry_clear(entry, X86_FEATURE_NX);
printk(KERN_INFO "kvm: guest NX capability removed\n"); printk(KERN_INFO "kvm: guest NX capability removed\n");
} }
} }
@ -385,7 +375,7 @@ static inline void do_cpuid_7_mask(struct kvm_cpuid_entry2 *entry)
entry->ebx &= kvm_cpuid_7_0_ebx_x86_features; entry->ebx &= kvm_cpuid_7_0_ebx_x86_features;
cpuid_mask(&entry->ebx, CPUID_7_0_EBX); cpuid_mask(&entry->ebx, CPUID_7_0_EBX);
/* TSC_ADJUST is emulated */ /* TSC_ADJUST is emulated */
entry->ebx |= F(TSC_ADJUST); cpuid_entry_set(entry, X86_FEATURE_TSC_ADJUST);
entry->ecx &= kvm_cpuid_7_0_ecx_x86_features; entry->ecx &= kvm_cpuid_7_0_ecx_x86_features;
f_la57 = cpuid_entry_get(entry, X86_FEATURE_LA57); f_la57 = cpuid_entry_get(entry, X86_FEATURE_LA57);
@ -396,21 +386,21 @@ static inline void do_cpuid_7_mask(struct kvm_cpuid_entry2 *entry)
entry->ecx |= f_pku; entry->ecx |= f_pku;
/* PKU is not yet implemented for shadow paging. */ /* PKU is not yet implemented for shadow paging. */
if (!tdp_enabled || !boot_cpu_has(X86_FEATURE_OSPKE)) if (!tdp_enabled || !boot_cpu_has(X86_FEATURE_OSPKE))
entry->ecx &= ~F(PKU); cpuid_entry_clear(entry, X86_FEATURE_PKU);
entry->edx &= kvm_cpuid_7_0_edx_x86_features; entry->edx &= kvm_cpuid_7_0_edx_x86_features;
cpuid_mask(&entry->edx, CPUID_7_EDX); cpuid_mask(&entry->edx, CPUID_7_EDX);
if (boot_cpu_has(X86_FEATURE_IBPB) && boot_cpu_has(X86_FEATURE_IBRS)) if (boot_cpu_has(X86_FEATURE_IBPB) && boot_cpu_has(X86_FEATURE_IBRS))
entry->edx |= F(SPEC_CTRL); cpuid_entry_set(entry, X86_FEATURE_SPEC_CTRL);
if (boot_cpu_has(X86_FEATURE_STIBP)) if (boot_cpu_has(X86_FEATURE_STIBP))
entry->edx |= F(INTEL_STIBP); cpuid_entry_set(entry, X86_FEATURE_INTEL_STIBP);
if (boot_cpu_has(X86_FEATURE_AMD_SSBD)) if (boot_cpu_has(X86_FEATURE_AMD_SSBD))
entry->edx |= F(SPEC_CTRL_SSBD); cpuid_entry_set(entry, X86_FEATURE_SPEC_CTRL_SSBD);
/* /*
* We emulate ARCH_CAPABILITIES in software even * We emulate ARCH_CAPABILITIES in software even
* if the host doesn't support it. * if the host doesn't support it.
*/ */
entry->edx |= F(ARCH_CAPABILITIES); cpuid_entry_set(entry, X86_FEATURE_ARCH_CAPABILITIES);
break; break;
case 1: case 1:
entry->eax &= kvm_cpuid_7_1_eax_x86_features; entry->eax &= kvm_cpuid_7_1_eax_x86_features;
@ -522,7 +512,7 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
cpuid_mask(&entry->ecx, CPUID_1_ECX); cpuid_mask(&entry->ecx, CPUID_1_ECX);
/* we support x2apic emulation even if host does not support /* we support x2apic emulation even if host does not support
* it since we emulate x2apic in software */ * it since we emulate x2apic in software */
entry->ecx |= F(X2APIC); cpuid_entry_set(entry, X86_FEATURE_X2APIC);
break; break;
/* function 2 entries are STATEFUL. That is, repeated cpuid commands /* function 2 entries are STATEFUL. That is, repeated cpuid commands
* may return different values. This forces us to get_cpu() before * may return different values. This forces us to get_cpu() before
@ -737,22 +727,22 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
* record that in cpufeatures so use them. * record that in cpufeatures so use them.
*/ */
if (boot_cpu_has(X86_FEATURE_IBPB)) if (boot_cpu_has(X86_FEATURE_IBPB))
entry->ebx |= F(AMD_IBPB); cpuid_entry_set(entry, X86_FEATURE_AMD_IBPB);
if (boot_cpu_has(X86_FEATURE_IBRS)) if (boot_cpu_has(X86_FEATURE_IBRS))
entry->ebx |= F(AMD_IBRS); cpuid_entry_set(entry, X86_FEATURE_AMD_IBRS);
if (boot_cpu_has(X86_FEATURE_STIBP)) if (boot_cpu_has(X86_FEATURE_STIBP))
entry->ebx |= F(AMD_STIBP); cpuid_entry_set(entry, X86_FEATURE_AMD_STIBP);
if (boot_cpu_has(X86_FEATURE_SPEC_CTRL_SSBD)) if (boot_cpu_has(X86_FEATURE_SPEC_CTRL_SSBD))
entry->ebx |= F(AMD_SSBD); cpuid_entry_set(entry, X86_FEATURE_AMD_SSBD);
if (!boot_cpu_has_bug(X86_BUG_SPEC_STORE_BYPASS)) if (!boot_cpu_has_bug(X86_BUG_SPEC_STORE_BYPASS))
entry->ebx |= F(AMD_SSB_NO); cpuid_entry_set(entry, X86_FEATURE_AMD_SSB_NO);
/* /*
* The preference is to use SPEC CTRL MSR instead of the * The preference is to use SPEC CTRL MSR instead of the
* VIRT_SPEC MSR. * VIRT_SPEC MSR.
*/ */
if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) && if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) &&
!boot_cpu_has(X86_FEATURE_AMD_SSBD)) !boot_cpu_has(X86_FEATURE_AMD_SSBD))
entry->ebx |= F(VIRT_SSBD); cpuid_entry_set(entry, X86_FEATURE_VIRT_SSBD);
break; break;
} }
case 0x80000019: case 0x80000019:

32
arch/x86/kvm/cpuid.h
View File

@ -135,6 +135,38 @@ static __always_inline bool cpuid_entry_has(struct kvm_cpuid_entry2 *entry,
return cpuid_entry_get(entry, x86_feature); return cpuid_entry_get(entry, x86_feature);
} }
static __always_inline void cpuid_entry_clear(struct kvm_cpuid_entry2 *entry,
unsigned int x86_feature)
{
u32 *reg = cpuid_entry_get_reg(entry, x86_feature);
*reg &= ~__feature_bit(x86_feature);
}
static __always_inline void cpuid_entry_set(struct kvm_cpuid_entry2 *entry,
unsigned int x86_feature)
{
u32 *reg = cpuid_entry_get_reg(entry, x86_feature);
*reg |= __feature_bit(x86_feature);
}
static __always_inline void cpuid_entry_change(struct kvm_cpuid_entry2 *entry,
unsigned int x86_feature,
bool set)
{
u32 *reg = cpuid_entry_get_reg(entry, x86_feature);
/*
* Open coded instead of using cpuid_entry_{clear,set}() to coerce the
* compiler into using CMOV instead of Jcc when possible.
*/
if (set)
*reg |= __feature_bit(x86_feature);
else
*reg &= ~__feature_bit(x86_feature);
}
static __always_inline u32 *guest_cpuid_get_register(struct kvm_vcpu *vcpu, static __always_inline u32 *guest_cpuid_get_register(struct kvm_vcpu *vcpu,
unsigned int x86_feature) unsigned int x86_feature)
{ {

11
arch/x86/kvm/svm.c
View File

@ -6033,19 +6033,17 @@ static void svm_cpuid_update(struct kvm_vcpu *vcpu)
APICV_INHIBIT_REASON_NESTED); APICV_INHIBIT_REASON_NESTED);
} }
#define F feature_bit
static void svm_set_supported_cpuid(struct kvm_cpuid_entry2 *entry) static void svm_set_supported_cpuid(struct kvm_cpuid_entry2 *entry)
{ {
switch (entry->function) { switch (entry->function) {
case 0x80000001: case 0x80000001:
if (nested) if (nested)
entry->ecx |= (1 << 2); /* Set SVM bit */ cpuid_entry_set(entry, X86_FEATURE_SVM);
break; break;
case 0x80000008: case 0x80000008:
if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) || if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) ||
boot_cpu_has(X86_FEATURE_AMD_SSBD)) boot_cpu_has(X86_FEATURE_AMD_SSBD))
entry->ebx |= F(VIRT_SSBD); cpuid_entry_set(entry, X86_FEATURE_VIRT_SSBD);
break; break;
case 0x8000000A: case 0x8000000A:
entry->eax = 1; /* SVM revision 1 */ entry->eax = 1; /* SVM revision 1 */
@ -6057,12 +6055,11 @@ static void svm_set_supported_cpuid(struct kvm_cpuid_entry2 *entry)
/* Support next_rip if host supports it */ /* Support next_rip if host supports it */
if (boot_cpu_has(X86_FEATURE_NRIPS)) if (boot_cpu_has(X86_FEATURE_NRIPS))
entry->edx |= F(NRIPS); cpuid_entry_set(entry, X86_FEATURE_NRIPS);
/* Support NPT for the guest if enabled */ /* Support NPT for the guest if enabled */
if (npt_enabled) if (npt_enabled)
entry->edx |= F(NPT); cpuid_entry_set(entry, X86_FEATURE_NPT);
} }
} }