leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: cedrus: Add missing v4l2_ctrl_request_hdl_put()

Browse Source 
The check for a required control in the request was missing a call to
v4l2_ctrl_request_hdl_put() in the error path. Fix it.

Fixes: 50e761516f ("media: platform: Add Cedrus VPU decoder driver")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Ezequiel Garcia
2020-08-13 21:18:33 +02:00
committed by Mauro Carvalho Chehab
parent 2e7c8fb894
commit b30063976f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/media/sunxi/cedrus/cedrus.c
View File

@@ -199,6 +199,7 @@ static int cedrus_request_validate(struct media_request *req)
struct v4l2_ctrl *ctrl_test; struct v4l2_ctrl *ctrl_test;
unsigned int count; unsigned int count;
unsigned int i; unsigned int i;
int ret = 0;
list_for_each_entry(obj, &req->objects, list) { list_for_each_entry(obj, &req->objects, list) {
struct vb2_buffer *vb; struct vb2_buffer *vb;
@@ -243,12 +244,16 @@ static int cedrus_request_validate(struct media_request *req)
if (!ctrl_test) { if (!ctrl_test) {
v4l2_info(&ctx->dev->v4l2_dev, v4l2_info(&ctx->dev->v4l2_dev,
"Missing required codec control\n"); "Missing required codec control\n");
return -ENOENT; ret = -ENOENT;
break;
} }
} }
v4l2_ctrl_request_hdl_put(hdl); v4l2_ctrl_request_hdl_put(hdl);
if (ret)
return ret;
return vb2_request_validate(req); return vb2_request_validate(req);
} }