leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: rcar-vin: Remove unneeded calls to pm_runtime_{enable, disable}

Browse Source 
Runtime PM is already enabled unconditionally when the driver is probed
and disabled when it's removed. There is no point in doing it again for
Gen2 when opening and closing the video device.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Niklas Söderlund 2019-06-12 19:45:41 -04:00 committed by Mauro Carvalho Chehab
parent a244fabc15
commit b2ef816c3d
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/platform/rcar-vin/rcar-v4l2.c
View File

@ -797,8 +797,6 @@ static int rvin_initialize_device(struct file *file)
if (ret < 0)
return ret;
pm_runtime_enable(&vin->vdev.dev);
/*
* Try to configure with default parameters. Notice: this is the
* very first open, so, we cannot race against other calls,
@ -813,7 +811,6 @@ static int rvin_initialize_device(struct file *file)
return 0;
esfmt:
pm_runtime_disable(&vin->vdev.dev);
rvin_power_off(vin);
return ret;
@ -863,10 +860,8 @@ static int rvin_release(struct file *file)
* If this was the last open file.
* Then de-initialize hw module.
*/
if (fh_singular) {
pm_runtime_disable(&vin->vdev.dev);
if (fh_singular)
rvin_power_off(vin);
}
mutex_unlock(&vin->lock);