leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ksmbd: uninitialized variable in create_socket()

Browse Source 
The "ksmbd_socket" variable is not initialized on this error path.

Cc: stable@vger.kernel.org
Fixes: 0626e6641f ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Dan Carpenter 2022-01-15 14:49:00 +03:00 committed by Steve French
parent 2fd5dcb1c8
commit b207602fb0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/ksmbd/transport_tcp.c
View File

@ -404,7 +404,7 @@ static int create_socket(struct interface *iface)
&ksmbd_socket); &ksmbd_socket);
if (ret) { if (ret) {
pr_err("Can't create socket for ipv4: %d\n", ret); pr_err("Can't create socket for ipv4: %d\n", ret);
goto out_error; goto out_clear;
} }
sin.sin_family = PF_INET; sin.sin_family = PF_INET;
@ -462,6 +462,7 @@ static int create_socket(struct interface *iface)
out_error: out_error:
tcp_destroy_socket(ksmbd_socket); tcp_destroy_socket(ksmbd_socket);
out_clear:
iface->ksmbd_socket = NULL; iface->ksmbd_socket = NULL;
return ret; return ret;
} }