leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: dwc3: Fix dereferencing of null dwc->usb_psy

Browse Source 
Currently the null check logic on dwc->usb_psy is inverted as it allows
calls to power_supply_put with a null dwc->usb_psy causing a null
pointer dereference. Fix this by removing the ! operator.

Addresses-Coverity: ("Dereference after null check")
Fixes: 59fa3def35de ("usb: dwc3: add a power supply for current control")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210303095826.6143-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Colin Ian King 2021-03-03 09:58:26 +00:00 committed by Greg Kroah-Hartman
parent 92d1e87e62
commit b0bf77cd38
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/dwc3/core.c
View File

@ -1628,7 +1628,7 @@ disable_clks:
assert_reset:
reset_control_assert(dwc->reset);
if (!dwc->usb_psy)
if (dwc->usb_psy)
power_supply_put(dwc->usb_psy);
return ret;
@ -1653,7 +1653,7 @@ static int dwc3_remove(struct platform_device *pdev)
dwc3_free_event_buffers(dwc);
dwc3_free_scratch_buffers(dwc);
if (!dwc->usb_psy)
if (dwc->usb_psy)
power_supply_put(dwc->usb_psy);
return 0;