leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: bcm2835-audio: fix empty-body warning

Browse Source 
gcc-7 warns about debug statements being left out here:

drivers/staging/bcm2835-audio/bcm2835-vchiq.c: In function 'bcm2835_audio_set_ctls':
drivers/staging/bcm2835-audio/bcm2835-vchiq.c:572:54: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]

It's better to use no_printk(), which has the added advantage of checking
the format strings.

Fixes: 23b028c871 ("staging: bcm2835-audio: initial staging submission")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Arnd Bergmann 2017-02-01 17:22:25 +01:00 committed by Greg Kroah-Hartman
parent fe822dc6c1
commit b07525b89f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/bcm2835-audio/bcm2835-vchiq.c
View File

@ -50,9 +50,9 @@
#define LOG_DBG( fmt, arg... ) pr_info( "%s:%d " fmt, __func__, __LINE__, ##arg)
#else
#define LOG_ERR( fmt, arg... ) pr_err( "%s:%d " fmt, __func__, __LINE__, ##arg)
#define LOG_WARN( fmt, arg... )
#define LOG_INFO( fmt, arg... )
#define LOG_DBG( fmt, arg... )
#define LOG_WARN( fmt, arg... ) no_printk(fmt, ##arg)
#define LOG_INFO( fmt, arg... ) no_printk(fmt, ##arg)
#define LOG_DBG( fmt, arg... ) no_printk(fmt, ##arg)
#endif
struct bcm2835_audio_instance {