From afc1990e089f501d686bb95b98146fc7ba23347f Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Fri, 22 Feb 2019 09:29:02 +0300 Subject: [PATCH] RDMA/core: Fix a WARN() message The first parameter of WARN_ONCE() is a condition, then following parameters are the message. In this case, we left out the condition so it will just print the ops->type string. Fixes: 3856ec4b93c9 ("RDMA/core: Add RDMA_NLDEV_CMD_NEWLINK/DELLINK support") Signed-off-by: Dan Carpenter Reviewed-by: Majd Dibbiny Reviewed-by: Steve Wise Signed-off-by: Jason Gunthorpe --- drivers/infiniband/core/nldev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index 5e94dc87f04f..11ed58d3fce5 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -1222,10 +1222,8 @@ out: void rdma_link_register(struct rdma_link_ops *ops) { down_write(&link_ops_rwsem); - if (link_ops_get(ops->type)) { - WARN_ONCE("Duplicate rdma_link_ops! %s\n", ops->type); + if (WARN_ON_ONCE(link_ops_get(ops->type))) goto out; - } list_add(&ops->list, &link_ops); out: up_write(&link_ops_rwsem);