leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ALSA: echoaudio: constify snd_pcm_ops structures

Browse Source 
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Arvind Yadav 2017-08-10 17:17:34 +05:30 committed by Takashi Iwai
parent 0b5b233915
commit afa04880f4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/pci/echoaudio/echoaudio.c
View File

@ -826,7 +826,7 @@ static snd_pcm_uframes_t pcm_pointer(struct snd_pcm_substream *substream)
/* pcm *_ops structures */ /* pcm *_ops structures */
static struct snd_pcm_ops analog_playback_ops = { static const struct snd_pcm_ops analog_playback_ops = {
.open = pcm_analog_out_open, .open = pcm_analog_out_open,
.close = pcm_close, .close = pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,
@ -837,7 +837,7 @@ static struct snd_pcm_ops analog_playback_ops = {
.pointer = pcm_pointer, .pointer = pcm_pointer,
.page = snd_pcm_sgbuf_ops_page, .page = snd_pcm_sgbuf_ops_page,
}; };
static struct snd_pcm_ops analog_capture_ops = { static const struct snd_pcm_ops analog_capture_ops = {
.open = pcm_analog_in_open, .open = pcm_analog_in_open,
.close = pcm_close, .close = pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,
@ -850,7 +850,7 @@ static struct snd_pcm_ops analog_capture_ops = {
}; };
#ifdef ECHOCARD_HAS_DIGITAL_IO #ifdef ECHOCARD_HAS_DIGITAL_IO
#ifndef ECHOCARD_HAS_VMIXER #ifndef ECHOCARD_HAS_VMIXER
static struct snd_pcm_ops digital_playback_ops = { static const struct snd_pcm_ops digital_playback_ops = {
.open = pcm_digital_out_open, .open = pcm_digital_out_open,
.close = pcm_close, .close = pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,
@ -862,7 +862,7 @@ static struct snd_pcm_ops digital_playback_ops = {
.page = snd_pcm_sgbuf_ops_page, .page = snd_pcm_sgbuf_ops_page,
}; };
#endif /* !ECHOCARD_HAS_VMIXER */ #endif /* !ECHOCARD_HAS_VMIXER */
static struct snd_pcm_ops digital_capture_ops = { static const struct snd_pcm_ops digital_capture_ops = {
.open = pcm_digital_in_open, .open = pcm_digital_in_open,
.close = pcm_close, .close = pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,