leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc: qcom: cmd-db: replace strncpy() with strscpy_pad()

Browse Source 
The use of strncpy() is considered deprecated for NUL-terminated
strings[1].  Replace strncpy() with strscpy_pad(), to keep existing
pad-behavior of strncpy.  This fixes W=1 warning:

  drivers/soc/qcom/cmd-db.c: In function ‘cmd_db_get_header.part.0’:
  drivers/soc/qcom/cmd-db.c:151:9: warning: ‘strncpy’ specified bound 8 equals destination size [-Wstringop-truncation]
    151 |         strncpy(query, id, sizeof(query));

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220519073301.7072-1-krzysztof.kozlowski@linaro.org
This commit is contained in:
Krzysztof Kozlowski 2022-05-19 09:33:00 +02:00 committed by Bjorn Andersson
parent ebf21bbc2f
commit ac0126a017
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/soc/qcom/cmd-db.c
View File

@ -148,7 +148,7 @@ static int cmd_db_get_header(const char *id, const struct entry_header **eh,
return ret; return ret;
/* Pad out query string to same length as in DB */ /* Pad out query string to same length as in DB */
strncpy(query, id, sizeof(query)); strscpy_pad(query, id, sizeof(query));
for (i = 0; i < MAX_SLV_ID; i++) { for (i = 0; i < MAX_SLV_ID; i++) {
rsc_hdr = &cmd_db_header->header[i]; rsc_hdr = &cmd_db_header->header[i];