leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] tda10071: add missing error status when probe() fails

Browse Source 
We must return -ENODEV error on case probe() fails to detect chip.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Antti Palosaari 2015-06-06 08:11:16 -03:00 committed by Mauro Carvalho Chehab
parent 4347df6a7f
commit ab80b19bb9
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/media/dvb-frontends/tda10071.c
View File

@ -1348,18 +1348,30 @@ static int tda10071_probe(struct i2c_client *client,
/* chip ID */ /* chip ID */
ret = tda10071_rd_reg(dev, 0xff, &u8tmp); ret = tda10071_rd_reg(dev, 0xff, &u8tmp);
if (ret || u8tmp != 0x0f) if (ret)
goto err_kfree; goto err_kfree;
if (u8tmp != 0x0f) {
ret = -ENODEV;
goto err_kfree;
}
/* chip type */ /* chip type */
ret = tda10071_rd_reg(dev, 0xdd, &u8tmp); ret = tda10071_rd_reg(dev, 0xdd, &u8tmp);
if (ret || u8tmp != 0x00) if (ret)
goto err_kfree; goto err_kfree;
if (u8tmp != 0x00) {
ret = -ENODEV;
goto err_kfree;
}
/* chip version */ /* chip version */
ret = tda10071_rd_reg(dev, 0xfe, &u8tmp); ret = tda10071_rd_reg(dev, 0xfe, &u8tmp);
if (ret || u8tmp != 0x01) if (ret)
goto err_kfree; goto err_kfree;
if (u8tmp != 0x01) {
ret = -ENODEV;
goto err_kfree;
}
/* create dvb_frontend */ /* create dvb_frontend */
memcpy(&dev->fe.ops, &tda10071_ops, sizeof(struct dvb_frontend_ops)); memcpy(&dev->fe.ops, &tda10071_ops, sizeof(struct dvb_frontend_ops));